Commit 538ec8f8 authored by Pierre d'Herbemont's avatar Pierre d'Herbemont

macosx: In bookmarks's dealloc, we shouldn't release the p_old_input ptr, as...

macosx: In bookmarks's dealloc, we shouldn't release the p_old_input ptr, as we have already released it.

This should fix a crash reported in our bugreport ml.
parent d4dec3d8
...@@ -76,8 +76,6 @@ static VLCBookmarks *_o_sharedInstance = nil; ...@@ -76,8 +76,6 @@ static VLCBookmarks *_o_sharedInstance = nil;
- (void)dealloc - (void)dealloc
{ {
if( p_old_input )
vlc_object_release( p_old_input );
[super dealloc]; [super dealloc];
} }
...@@ -188,6 +186,9 @@ static VLCBookmarks *_o_sharedInstance = nil; ...@@ -188,6 +186,9 @@ static VLCBookmarks *_o_sharedInstance = nil;
pp_bookmarks[row]->i_byte_offset] stringValue]]; pp_bookmarks[row]->i_byte_offset] stringValue]];
} }
/* Just keep the pointer value to check if it
* changes. Note, we don't need to keep a reference to the object.
* so release it now. */
p_old_input = p_input; p_old_input = p_input;
vlc_object_release( p_input ); vlc_object_release( p_input );
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment