Commit f6282f4d authored by Gerrit Renker's avatar Gerrit Renker Committed by David S. Miller

[DCCP]: Warn when discarding packet due to internal errors

This adds a (debug) warning message which is triggered whenever a packet is
discarded due to send failure.

It also adds a conditional, so that an interruption during dccp_wait_for_ccid
is not treated as a `BUG': the rationale is that interruptions are external,
whereas bug warnings are concerned with the internals.
Signed-off-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
Acked-by: default avatarIan McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@mandriva.com>
parent bf58a381
...@@ -241,7 +241,7 @@ void dccp_write_xmit(struct sock *sk, int block) ...@@ -241,7 +241,7 @@ void dccp_write_xmit(struct sock *sk, int block)
break; break;
} else } else
err = dccp_wait_for_ccid(sk, skb); err = dccp_wait_for_ccid(sk, skb);
if (err) if (err && err != -EINTR)
DCCP_BUG("err=%d after dccp_wait_for_ccid", err); DCCP_BUG("err=%d after dccp_wait_for_ccid", err);
} }
...@@ -267,9 +267,11 @@ void dccp_write_xmit(struct sock *sk, int block) ...@@ -267,9 +267,11 @@ void dccp_write_xmit(struct sock *sk, int block)
if (err) if (err)
DCCP_BUG("err=%d after ccid_hc_tx_packet_sent", DCCP_BUG("err=%d after ccid_hc_tx_packet_sent",
err); err);
} else } else {
dccp_pr_debug("packet discarded\n");
kfree(skb); kfree(skb);
} }
}
} }
int dccp_retransmit_skb(struct sock *sk, struct sk_buff *skb) int dccp_retransmit_skb(struct sock *sk, struct sk_buff *skb)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment