Commit f01d1d54 authored by Alexey Dobriyan's avatar Alexey Dobriyan Committed by Linus Torvalds

seq_file: fix big-enough lseek() + read()

lseek() further than length of the file will leave stale ->index
(second-to-last during iteration). Next seq_read() will not notice
that ->f_pos is big enough to return 0, but will print last item
as if ->f_pos is pointing to it.

Introduced in commit cb510b81
aka "seq_file: more atomicity in traverse()".
Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 33da8892
...@@ -102,6 +102,7 @@ static int traverse(struct seq_file *m, loff_t offset) ...@@ -102,6 +102,7 @@ static int traverse(struct seq_file *m, loff_t offset)
p = m->op->next(m, p, &index); p = m->op->next(m, p, &index);
} }
m->op->stop(m, p); m->op->stop(m, p);
m->index = index;
return error; return error;
Eoverflow: Eoverflow:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment