Commit ecca0683 authored by Julia Lawall's avatar Julia Lawall Committed by Dave Airlie

drm: Move a dereference below a NULL test

If the NULL test is necessary, then the dereference should be moved below
the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarDave Airlie <airlied@linux.ie>
parent ba0ab823
...@@ -489,7 +489,7 @@ int drm_put_minor(struct drm_minor **minor_p) ...@@ -489,7 +489,7 @@ int drm_put_minor(struct drm_minor **minor_p)
*/ */
void drm_put_dev(struct drm_device *dev) void drm_put_dev(struct drm_device *dev)
{ {
struct drm_driver *driver = dev->driver; struct drm_driver *driver;
struct drm_map_list *r_list, *list_temp; struct drm_map_list *r_list, *list_temp;
DRM_DEBUG("\n"); DRM_DEBUG("\n");
...@@ -498,6 +498,7 @@ void drm_put_dev(struct drm_device *dev) ...@@ -498,6 +498,7 @@ void drm_put_dev(struct drm_device *dev)
DRM_ERROR("cleanup called no dev\n"); DRM_ERROR("cleanup called no dev\n");
return; return;
} }
driver = dev->driver;
drm_vblank_cleanup(dev); drm_vblank_cleanup(dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment