Commit ea58ceb5 authored by David Howells's avatar David Howells Committed by Linus Torvalds

FS-Cache: Avoid maybe-used-uninitialised warning on variable

Andrew Morton's compiler sees the following warning in FS-Cache:

fs/fscache/object-list.c: In function 'fscache_objlist_lookup':
fs/fscache/object-list.c:94: warning: 'obj' may be used uninitialized in this function

which my compiler doesn't.  This is a false positive as obj can only be
used in the comparison against minobj if minobj has been set to something
other than NULL, but for that to happen, obj has to be first set to
something.

Deal with this by preclearing obj too.
Reported-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 06a7f711
...@@ -91,7 +91,7 @@ EXPORT_SYMBOL(fscache_object_destroy); ...@@ -91,7 +91,7 @@ EXPORT_SYMBOL(fscache_object_destroy);
*/ */
static struct fscache_object *fscache_objlist_lookup(loff_t *_pos) static struct fscache_object *fscache_objlist_lookup(loff_t *_pos)
{ {
struct fscache_object *pobj, *obj, *minobj = NULL; struct fscache_object *pobj, *obj = NULL, *minobj = NULL;
struct rb_node *p; struct rb_node *p;
unsigned long pos; unsigned long pos;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment