Commit df97992c authored by Ingo Molnar's avatar Ingo Molnar

perf record/report: Fix PID/COMM handling

Fix two bugs causing lost comm mappings:

 - initial PID is not 0 but getpid()

 - when we are unable to handle an mmap event, dont assume the event
   itself is broken - try to parse the stream. This way we wont lose
   comm events.

Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
LKML-Reference: <new-submission>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 3aff27ca
...@@ -430,7 +430,7 @@ static int __cmd_record(int argc, const char **argv) ...@@ -430,7 +430,7 @@ static int __cmd_record(int argc, const char **argv)
} }
if (!system_wide) { if (!system_wide) {
open_counters(-1, target_pid != -1 ? target_pid : 0); open_counters(-1, target_pid != -1 ? target_pid : getpid());
} else for (i = 0; i < nr_cpus; i++) } else for (i = 0; i < nr_cpus; i++)
open_counters(i, target_pid); open_counters(i, target_pid);
......
...@@ -852,7 +852,7 @@ process_mmap_event(event_t *event, unsigned long offset, unsigned long head) ...@@ -852,7 +852,7 @@ process_mmap_event(event_t *event, unsigned long offset, unsigned long head)
if (thread == NULL || map == NULL) { if (thread == NULL || map == NULL) {
dprintf("problem processing PERF_EVENT_MMAP, skipping event.\n"); dprintf("problem processing PERF_EVENT_MMAP, skipping event.\n");
return -1; return 0;
} }
thread__insert_map(thread, map); thread__insert_map(thread, map);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment