Commit ccef0864 authored by H. Peter Anvin's avatar H. Peter Anvin

x86, mm: Correct the implementation of is_untracked_pat_range()

The semantics the PAT code expect of is_untracked_pat_range() is "is
this range completely contained inside the untracked region."  This
means that checkin 8a271389 was
technically wrong, because the implementation needlessly confusing.

The sane interface is for it to take a semiclosed range like just
about everything else (as evidenced by the sheer number of "- 1"'s
removed by that patch) so change the actual implementation to match.
Reported-by: default avatarSuresh Siddha <suresh.b.siddha@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jack Steiner <steiner@sgi.com>
Signed-off-by: default avatarH. Peter Anvin <hpa@zytor.com>
LKML-Reference: <20091119202341.GA4420@sgi.com>
parent dd4377b0
...@@ -133,9 +133,13 @@ extern void e820_reserve_resources_late(void); ...@@ -133,9 +133,13 @@ extern void e820_reserve_resources_late(void);
extern void setup_memory_map(void); extern void setup_memory_map(void);
extern char *default_machine_specific_memory_setup(void); extern char *default_machine_specific_memory_setup(void);
/*
* Returns true iff the specified range [s,e) is completely contained inside
* the ISA region.
*/
static inline bool is_ISA_range(u64 s, u64 e) static inline bool is_ISA_range(u64 s, u64 e)
{ {
return s >= ISA_START_ADDRESS && e < ISA_END_ADDRESS; return s >= ISA_START_ADDRESS && e <= ISA_END_ADDRESS;
} }
#endif /* __KERNEL__ */ #endif /* __KERNEL__ */
......
...@@ -39,7 +39,7 @@ static u64 gru_start_paddr, gru_end_paddr; ...@@ -39,7 +39,7 @@ static u64 gru_start_paddr, gru_end_paddr;
static inline bool is_GRU_range(u64 start, u64 end) static inline bool is_GRU_range(u64 start, u64 end)
{ {
return start >= gru_start_paddr && end < gru_end_paddr; return start >= gru_start_paddr && end <= gru_end_paddr;
} }
static bool uv_is_untracked_pat_range(u64 start, u64 end) static bool uv_is_untracked_pat_range(u64 start, u64 end)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment