Commit c801147c authored by Egbert Eich's avatar Egbert Eich Committed by Linus Torvalds

[PATCH] SiS DRM: Fix possible NULL dereference

This fixes a NULL pointer reference in DRM.  The SiS driver tries to
allocate a big chunk of memory, but the return value is never checked.

Reported in Novell bugzilla #132271:
  https://bugzilla.novell.com/show_bug.cgi?id=132271Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent d2ef5ebb
...@@ -432,7 +432,10 @@ int drm_addctx(struct inode *inode, struct file *filp, ...@@ -432,7 +432,10 @@ int drm_addctx(struct inode *inode, struct file *filp,
if (ctx.handle != DRM_KERNEL_CONTEXT) { if (ctx.handle != DRM_KERNEL_CONTEXT) {
if (dev->driver->context_ctor) if (dev->driver->context_ctor)
dev->driver->context_ctor(dev, ctx.handle); if (!dev->driver->context_ctor(dev, ctx.handle)) {
DRM_DEBUG( "Running out of ctxs or memory.\n");
return -ENOMEM;
}
} }
ctx_entry = drm_alloc(sizeof(*ctx_entry), DRM_MEM_CTXLIST); ctx_entry = drm_alloc(sizeof(*ctx_entry), DRM_MEM_CTXLIST);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment