Commit c4a001b1 authored by Dominik Brodowski's avatar Dominik Brodowski Committed by Len Brown

ACPI: C-States: only demote on current bus mastering activity

Only if bus master activity is going on at the present, we should avoid
entering C3-type sleep, as it might be a faulty transition.  As long as the
bm_activity bitmask was based on the number of calls to the ACPI idle
function, looking at previous moments made sense.  Now, with it being based on
what happened this jiffy, looking at this jiffy should be sufficient.
Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent c5ab81ca
...@@ -287,10 +287,10 @@ static void acpi_processor_idle(void) ...@@ -287,10 +287,10 @@ static void acpi_processor_idle(void)
pr->power.bm_check_timestamp = jiffies; pr->power.bm_check_timestamp = jiffies;
/* /*
* Apply bus mastering demotion policy. Automatically demote * If bus mastering is or was active this jiffy, demote
* to avoid a faulty transition. Note that the processor * to avoid a faulty transition. Note that the processor
* won't enter a low-power state during this call (to this * won't enter a low-power state during this call (to this
* funciton) but should upon the next. * function) but should upon the next.
* *
* TBD: A better policy might be to fallback to the demotion * TBD: A better policy might be to fallback to the demotion
* state (use it for this quantum only) istead of * state (use it for this quantum only) istead of
...@@ -298,7 +298,8 @@ static void acpi_processor_idle(void) ...@@ -298,7 +298,8 @@ static void acpi_processor_idle(void)
* qualification. This may, however, introduce DMA * qualification. This may, however, introduce DMA
* issues (e.g. floppy DMA transfer overrun/underrun). * issues (e.g. floppy DMA transfer overrun/underrun).
*/ */
if (pr->power.bm_activity & cx->demotion.threshold.bm) { if ((pr->power.bm_activity & 0x1) &&
cx->demotion.threshold.bm) {
local_irq_enable(); local_irq_enable();
next_state = cx->demotion.state; next_state = cx->demotion.state;
goto end; goto end;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment