Commit c1dcf772 authored by Roel Kluin's avatar Roel Kluin Committed by james toy

value cannot logically be less than START and greater than BUFFERSIZE.

#define EXTENDED_SENSE_START  18

// vi include/scsi/scsi_cmnd.h +105
#define SCSI_SENSE_BUFFERSIZE 	96

[akpm@linux-foundation.org: fix warning]
Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Cc: Willem Riede <osst@riede.org>
Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 6b519d4b
...@@ -2280,7 +2280,8 @@ static int st_set_options(struct scsi_tape *STp, long options) ...@@ -2280,7 +2280,8 @@ static int st_set_options(struct scsi_tape *STp, long options)
} else if (code == MT_ST_SET_CLN) { } else if (code == MT_ST_SET_CLN) {
value = (options & ~MT_ST_OPTIONS) & 0xff; value = (options & ~MT_ST_OPTIONS) & 0xff;
if (value != 0 && if (value != 0 &&
value < EXTENDED_SENSE_START && value >= SCSI_SENSE_BUFFERSIZE) (value < EXTENDED_SENSE_START ||
value >= SCSI_SENSE_BUFFERSIZE))
return (-EINVAL); return (-EINVAL);
STp->cln_mode = value; STp->cln_mode = value;
STp->cln_sense_mask = (options >> 8) & 0xff; STp->cln_sense_mask = (options >> 8) & 0xff;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment