Commit b686c5d3 authored by Troy Kisky's avatar Troy Kisky Committed by Kevin Hilman

I2C: DaVinci: remove useless IVR read

Interrupts are enabled at the point where
the DAVINCI_I2C_IVR_REG is read, so unless
an interrupt happened just at that moment,
no interrupt would be pending. Even though
documentation implies you should do this,
I see no reason. If slave support is added,
this read would cause a hard to reproduce bug.
Signed-off-by: default avatarTroy Kisky <troy.kisky@boundarydevices.com>
Signed-off-by: default avatarKevin Hilman <khilman@mvista.com>
parent 917aff51
...@@ -245,7 +245,6 @@ i2c_davinci_xfer_msg(struct i2c_adapter *adap, struct i2c_msg *msg, int stop) ...@@ -245,7 +245,6 @@ i2c_davinci_xfer_msg(struct i2c_adapter *adap, struct i2c_msg *msg, int stop)
struct davinci_i2c_dev *dev = i2c_get_adapdata(adap); struct davinci_i2c_dev *dev = i2c_get_adapdata(adap);
struct davinci_i2c_platform_data *pdata = dev->dev->platform_data; struct davinci_i2c_platform_data *pdata = dev->dev->platform_data;
u32 flag; u32 flag;
u32 stat;
u16 w; u16 w;
int r; int r;
#ifdef DAVINCI_HACK #ifdef DAVINCI_HACK
...@@ -284,11 +283,6 @@ i2c_davinci_xfer_msg(struct i2c_adapter *adap, struct i2c_msg *msg, int stop) ...@@ -284,11 +283,6 @@ i2c_davinci_xfer_msg(struct i2c_adapter *adap, struct i2c_msg *msg, int stop)
init_completion(&dev->cmd_complete); init_completion(&dev->cmd_complete);
dev->cmd_err = 0; dev->cmd_err = 0;
/* Clear any pending interrupts by reading the IVR */
do {
stat = davinci_i2c_read_reg(dev, DAVINCI_I2C_IVR_REG);
} while (stat);
/* Take I2C out of reset, configure it as master and set the /* Take I2C out of reset, configure it as master and set the
* start bit */ * start bit */
flag = DAVINCI_I2C_MDR_IRS | DAVINCI_I2C_MDR_MST | DAVINCI_I2C_MDR_STT; flag = DAVINCI_I2C_MDR_IRS | DAVINCI_I2C_MDR_MST | DAVINCI_I2C_MDR_STT;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment