Commit a0d045ca authored by Julia Lawall's avatar Julia Lawall Committed by Pierre Ossman

drivers/mmc: Move a dereference below a NULL test

In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarPierre Ossman <drzeus@drzeus.cx>
parent f9134319
...@@ -224,7 +224,7 @@ static inline void tmio_mmc_data_irq(struct tmio_mmc_host *host) ...@@ -224,7 +224,7 @@ static inline void tmio_mmc_data_irq(struct tmio_mmc_host *host)
{ {
void __iomem *ctl = host->ctl; void __iomem *ctl = host->ctl;
struct mmc_data *data = host->data; struct mmc_data *data = host->data;
struct mmc_command *stop = data->stop; struct mmc_command *stop;
host->data = NULL; host->data = NULL;
...@@ -232,6 +232,7 @@ static inline void tmio_mmc_data_irq(struct tmio_mmc_host *host) ...@@ -232,6 +232,7 @@ static inline void tmio_mmc_data_irq(struct tmio_mmc_host *host)
pr_debug("Spurious data end IRQ\n"); pr_debug("Spurious data end IRQ\n");
return; return;
} }
stop = data->stop;
/* FIXME - return correct transfer count on errors */ /* FIXME - return correct transfer count on errors */
if (!data->error) if (!data->error)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment