Commit a08b43ae authored by Jiri Slaby's avatar Jiri Slaby Committed by Greg Kroah-Hartman

USB: misc/vstusb, fix lock imbalance

Make sure we don't leak locked vstdev->lock in vstusb_write. Unlock
properly on one fail path.
Signed-off-by: default avatarJiri Slaby <jirislaby@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 46c9844c
...@@ -401,6 +401,7 @@ static ssize_t vstusb_write(struct file *file, const char __user *buffer, ...@@ -401,6 +401,7 @@ static ssize_t vstusb_write(struct file *file, const char __user *buffer,
} }
if (copy_from_user(buf, buffer, count)) { if (copy_from_user(buf, buffer, count)) {
mutex_unlock(&vstdev->lock);
dev_err(&dev->dev, "%s: can't copy_from_user\n", __func__); dev_err(&dev->dev, "%s: can't copy_from_user\n", __func__);
retval = -EFAULT; retval = -EFAULT;
goto exit; goto exit;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment