Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
L
linux-davinci
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
linux
linux-davinci
Commits
9e346820
Commit
9e346820
authored
Mar 15, 2007
by
Ralf Baechle
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[MIPS] RTLX: Don't use volatile; it's fragile.
Signed-off-by:
Ralf Baechle
<
ralf@linux-mips.org
>
parent
080e948c
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
16 additions
and
5 deletions
+16
-5
arch/mips/kernel/rtlx.c
arch/mips/kernel/rtlx.c
+16
-5
No files found.
arch/mips/kernel/rtlx.c
View file @
9e346820
...
...
@@ -146,7 +146,7 @@ static void stopping(int vpe)
int
rtlx_open
(
int
index
,
int
can_sleep
)
{
volatile
struct
rtlx_info
**
p
;
struct
rtlx_info
**
p
;
struct
rtlx_channel
*
chan
;
enum
rtlx_state
state
;
int
ret
=
0
;
...
...
@@ -179,13 +179,24 @@ int rtlx_open(int index, int can_sleep)
}
}
smp_rmb
();
if
(
*
p
==
NULL
)
{
if
(
can_sleep
)
{
__wait_event_interruptible
(
channel_wqs
[
index
].
lx_queue
,
*
p
!=
NULL
,
ret
);
if
(
ret
)
DEFINE_WAIT
(
wait
);
for
(;;)
{
prepare_to_wait
(
&
channel_wqs
[
index
].
lx_queue
,
&
wait
,
TASK_INTERRUPTIBLE
);
smp_rmb
();
if
(
*
p
!=
NULL
)
break
;
if
(
!
signal_pending
(
current
))
{
schedule
();
continue
;
}
ret
=
-
ERESTARTSYS
;
goto
out_fail
;
}
finish_wait
(
&
channel_wqs
[
index
].
lx_queue
,
&
wait
);
}
else
{
printk
(
" *vpe_get_shared is NULL. "
"Has an SP program been loaded?
\n
"
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment