Commit 9aa8dae7 authored by Mike Isely's avatar Mike Isely Committed by Greg Kroah-Hartman

cypress_m8: use usb_fill_int_urb where appropriate

Rather than directly filling in URB fields, it's safer to use
usb_fill_int_urb().  This improves robustness of the driver; URB
changes in the future will not go uninitialized here.  That point not
withstanding, this driver should at least be self-consistent.  Either
use usb_fill_int_urb() everywhere or don't bother with it all.
Signed-off-by: default avatarMike Isely <isely@pobox.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 0257fa9f
...@@ -820,9 +820,10 @@ send: ...@@ -820,9 +820,10 @@ send:
usb_serial_debug_data(debug, &port->dev, __FUNCTION__, port->interrupt_out_size, usb_serial_debug_data(debug, &port->dev, __FUNCTION__, port->interrupt_out_size,
port->interrupt_out_urb->transfer_buffer); port->interrupt_out_urb->transfer_buffer);
port->interrupt_out_urb->transfer_buffer_length = actual_size; usb_fill_int_urb(port->interrupt_out_urb, port->serial->dev,
port->interrupt_out_urb->dev = port->serial->dev; usb_sndintpipe(port->serial->dev, port->interrupt_out_endpointAddress),
port->interrupt_out_urb->interval = priv->write_urb_interval; port->interrupt_out_buffer, port->interrupt_out_size,
cypress_write_int_callback, port, priv->write_urb_interval);
result = usb_submit_urb (port->interrupt_out_urb, GFP_ATOMIC); result = usb_submit_urb (port->interrupt_out_urb, GFP_ATOMIC);
if (result) { if (result) {
dev_err(&port->dev, "%s - failed submitting write urb, error %d\n", __FUNCTION__, dev_err(&port->dev, "%s - failed submitting write urb, error %d\n", __FUNCTION__,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment