Commit 98701d1b authored by kalash nainwal's avatar kalash nainwal Committed by Linus Torvalds

(re)register_binfmt returns with -EBUSY

When a binary format is unregistered and re-registered, register_binfmt
fails with -EBUSY.  The reason is that unregister_binfmt does not set
fmt->next to NULL, and seeing (fmt->next != NULL), register_binfmt fails
with -EBUSY.

One can find his way around by explicitly setting fmt->next to NULL after
unregistering, but that is kind of unclean (one should better be using only
the interfaces, and not the interal members, isn't it?)

Attached one-liner can fix it.
Signed-off-by: default avatarKalash Nainwal <kalash.nainwal@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0f95b7fc
...@@ -100,6 +100,7 @@ int unregister_binfmt(struct linux_binfmt * fmt) ...@@ -100,6 +100,7 @@ int unregister_binfmt(struct linux_binfmt * fmt)
while (*tmp) { while (*tmp) {
if (fmt == *tmp) { if (fmt == *tmp) {
*tmp = fmt->next; *tmp = fmt->next;
fmt->next = NULL;
write_unlock(&binfmt_lock); write_unlock(&binfmt_lock);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment