Commit 86678dfd authored by Dave Airlie's avatar Dave Airlie

[PATCH] drm: Fix issue reported by Coverity in drivers/char/drm/via_irq.c

This patch tries to fix an issue reported in drivers/char/drm/via_irq.c by
Coverity, please review and apply if correct.

Error reported:
CID: 3444 Checker: REVERSE_INULL (help)
File: /export2/p4-coverity/mc2/linux26/drivers/char/drm/via_irq.c
Function: via_driver_irq_wait
Description: Pointer "dev_priv" dereferenced before NULL check

Patch Description:
 Move de-referencing dev_priv to after the NULL check.

Signed-off-by: Jayachandran C. <c.jayachandran at gmail.com>
Signed-off-by: default avatarDave Airlie <airlied@linux.ie>
parent 6246b612
......@@ -198,7 +198,7 @@ via_driver_irq_wait(drm_device_t * dev, unsigned int irq, int force_sequence,
unsigned int cur_irq_sequence;
drm_via_irq_t *cur_irq = dev_priv->via_irqs;
int ret = 0;
maskarray_t *masks = dev_priv->irq_masks;
maskarray_t *masks;
int real_irq;
DRM_DEBUG("%s\n", __FUNCTION__);
......@@ -222,6 +222,7 @@ via_driver_irq_wait(drm_device_t * dev, unsigned int irq, int force_sequence,
return DRM_ERR(EINVAL);
}
masks = dev_priv->irq_masks;
cur_irq += real_irq;
if (masks[real_irq][2] && !force_sequence) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment