Commit 698e96a8 authored by Volker Lendecke's avatar Volker Lendecke Committed by Steve French

Streamline SendReceiveBlockingLock: Use "goto out:" in an error condition

Streamline SendReceiveBlockingLock: Use "goto out:" in an error condition
Signed-off-by: default avatarVolker Lendecke <vl@samba.org>
Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
parent 17c8bfed
...@@ -1067,8 +1067,13 @@ SendReceiveBlockingLock(const unsigned int xid, struct cifsTconInfo *tcon, ...@@ -1067,8 +1067,13 @@ SendReceiveBlockingLock(const unsigned int xid, struct cifsTconInfo *tcon,
/* rcvd frame is ok */ /* rcvd frame is ok */
if (midQ->resp_buf && out_buf if ((midQ->resp_buf == NULL) || (out_buf == NULL)
&& (midQ->midState == MID_RESPONSE_RECEIVED)) { || (midQ->midState != MID_RESPONSE_RECEIVED)) {
rc = -EIO;
cERROR(1, ("Bad MID state?"));
goto out;
}
out_buf->smb_buf_length = receive_len; out_buf->smb_buf_length = receive_len;
memcpy((char *)out_buf + 4, memcpy((char *)out_buf + 4,
(char *)midQ->resp_buf + 4, (char *)midQ->resp_buf + 4,
...@@ -1098,10 +1103,6 @@ SendReceiveBlockingLock(const unsigned int xid, struct cifsTconInfo *tcon, ...@@ -1098,10 +1103,6 @@ SendReceiveBlockingLock(const unsigned int xid, struct cifsTconInfo *tcon,
/* do not count RFC1001 header */ + /* do not count RFC1001 header */ +
(2 * out_buf->WordCount) + 2 /* bcc */ ) (2 * out_buf->WordCount) + 2 /* bcc */ )
BCC(out_buf) = le16_to_cpu(BCC_LE(out_buf)); BCC(out_buf) = le16_to_cpu(BCC_LE(out_buf));
} else {
rc = -EIO;
cERROR(1, ("Bad MID state?"));
}
out: out:
DeleteMidQEntry(midQ); DeleteMidQEntry(midQ);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment