Commit 63bd8c48 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Linus Torvalds

Atari keyboard: incorporate additional review comments

Atari keyboard: incorporate additional review comments:
  o Kill reference to source file name
  o Return error value from input_register_device() instead of -ENOMEM
Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Michael Schmitz <schmitz@biophys.uni-duesseldorf.de>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 355aaffd
/* /*
* linux/arch/m68k/atari/atakeyb.c
*
* Atari Keyboard driver for 680x0 Linux * Atari Keyboard driver for 680x0 Linux
* *
* This file is subject to the terms and conditions of the GNU General Public * This file is subject to the terms and conditions of the GNU General Public
......
...@@ -217,7 +217,7 @@ static void atakbd_interrupt(unsigned char scancode, char down) ...@@ -217,7 +217,7 @@ static void atakbd_interrupt(unsigned char scancode, char down)
static int __init atakbd_init(void) static int __init atakbd_init(void)
{ {
int i; int i, error;
if (!MACH_IS_ATARI || !ATARIHW_PRESENT(ST_MFP)) if (!MACH_IS_ATARI || !ATARIHW_PRESENT(ST_MFP))
return -EIO; return -EIO;
...@@ -247,9 +247,10 @@ static int __init atakbd_init(void) ...@@ -247,9 +247,10 @@ static int __init atakbd_init(void)
} }
/* error check */ /* error check */
if (input_register_device(atakbd_dev)) { error = input_register_device(atakbd_dev);
if (error) {
input_free_device(atakbd_dev); input_free_device(atakbd_dev);
return -ENOMEM; return error;
} }
atari_input_keyboard_interrupt_hook = atakbd_interrupt; atari_input_keyboard_interrupt_hook = atakbd_interrupt;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment