Commit 5b8ef842 authored by Tejun Heo 's avatar Tejun Heo Committed by James Bottomley

[SCSI] remove spurious if tests from scsi_eh_{times_out|done}

'if' tests which check if eh_action isn't NULL in both
functions are always true.  Remove the redundant if's as it
can give wrong impressions.
Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent 0155a37e
...@@ -434,7 +434,6 @@ static void scsi_eh_times_out(struct scsi_cmnd *scmd) ...@@ -434,7 +434,6 @@ static void scsi_eh_times_out(struct scsi_cmnd *scmd)
SCSI_LOG_ERROR_RECOVERY(3, printk("%s: scmd:%p\n", __FUNCTION__, SCSI_LOG_ERROR_RECOVERY(3, printk("%s: scmd:%p\n", __FUNCTION__,
scmd)); scmd));
if (scmd->device->host->eh_action)
up(scmd->device->host->eh_action); up(scmd->device->host->eh_action);
} }
...@@ -457,7 +456,6 @@ static void scsi_eh_done(struct scsi_cmnd *scmd) ...@@ -457,7 +456,6 @@ static void scsi_eh_done(struct scsi_cmnd *scmd)
SCSI_LOG_ERROR_RECOVERY(3, printk("%s scmd: %p result: %x\n", SCSI_LOG_ERROR_RECOVERY(3, printk("%s scmd: %p result: %x\n",
__FUNCTION__, scmd, scmd->result)); __FUNCTION__, scmd, scmd->result));
if (scmd->device->host->eh_action)
up(scmd->device->host->eh_action); up(scmd->device->host->eh_action);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment