Commit 59192ed9 authored by Ian Dall's avatar Ian Dall Committed by Dave Kleikamp

JFS: Need to be root to create files with security context

It turns out this is due to some inverted logic in xattr.c
Signed-off-by: default avatarDave Kleikamp <shaggy@austin.ibm.com>
parent 6211502d
...@@ -790,12 +790,12 @@ static int can_set_xattr(struct inode *inode, const char *name, ...@@ -790,12 +790,12 @@ static int can_set_xattr(struct inode *inode, const char *name,
*/ */
return can_set_system_xattr(inode, name, value, value_len); return can_set_system_xattr(inode, name, value, value_len);
if(strncmp(name, XATTR_TRUSTED_PREFIX, XATTR_TRUSTED_PREFIX_LEN) != 0) if(strncmp(name, XATTR_TRUSTED_PREFIX, XATTR_TRUSTED_PREFIX_LEN) == 0)
return (capable(CAP_SYS_ADMIN) ? 0 : -EPERM); return (capable(CAP_SYS_ADMIN) ? 0 : -EPERM);
#ifdef CONFIG_JFS_SECURITY #ifdef CONFIG_JFS_SECURITY
if (strncmp(name, XATTR_SECURITY_PREFIX, XATTR_SECURITY_PREFIX_LEN) if (strncmp(name, XATTR_SECURITY_PREFIX, XATTR_SECURITY_PREFIX_LEN)
!= 0) == 0)
return 0; /* Leave it to the security module */ return 0; /* Leave it to the security module */
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment