Commit 4fc981ef authored by Tejun Heo's avatar Tejun Heo Committed by Jens Axboe

bio: always copy back data for copied kernel requests

When a read bio_copy_kern() request fails, the content of the bounce
buffer is not copied back.  However, as request failure doesn't
necessarily mean complete failure, the buffer state can be useful.
This behavior is also inconsistent with the user map counterpart and
causes the subtle difference between bounced and unbounced IO causes
confusion.

This patch makes bio_copy_kern_endio() ignore @err and always copy
back data on request completion.
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Cc: Boaz Harrosh <bharrosh@panasas.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: default avatarJens Axboe <jens.axboe@oracle.com>
parent 5f49f631
...@@ -1198,7 +1198,7 @@ static void bio_copy_kern_endio(struct bio *bio, int err) ...@@ -1198,7 +1198,7 @@ static void bio_copy_kern_endio(struct bio *bio, int err)
char *addr = page_address(bvec->bv_page); char *addr = page_address(bvec->bv_page);
int len = bmd->iovecs[i].bv_len; int len = bmd->iovecs[i].bv_len;
if (read && !err) if (read)
memcpy(p, addr, len); memcpy(p, addr, len);
__free_page(bvec->bv_page); __free_page(bvec->bv_page);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment