Commit 47881dd9 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

Staging: slicoss: remove VALID_ADDRESS macro

It's quite wierd, and doesn't even do anything on x86_64, so just delete
it.

Cc: Lior Dotan <liodot@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent a0a1cbef
...@@ -62,11 +62,6 @@ ...@@ -62,11 +62,6 @@
#endif #endif
#if SLIC_ASSERT_ENABLED #if SLIC_ASSERT_ENABLED
#ifdef CONFIG_X86_64
#define VALID_ADDRESS(p) (1)
#else
#define VALID_ADDRESS(p) (((u32)(p) & 0x80000000) || ((u32)(p) == 0))
#endif
#ifndef ASSERT #ifndef ASSERT
#define ASSERT(a) \ #define ASSERT(a) \
{ \ { \
......
...@@ -3818,13 +3818,11 @@ static void slic_cmdq_addcmdpage(struct adapter *adapter, u32 *page) ...@@ -3818,13 +3818,11 @@ static void slic_cmdq_addcmdpage(struct adapter *adapter, u32 *page)
cmdq = &adapter->cmdq_all; cmdq = &adapter->cmdq_all;
cmdq->count += cmdcnt; /* SLIC_CMDQ_CMDSINPAGE; mooktodo */ cmdq->count += cmdcnt; /* SLIC_CMDQ_CMDSINPAGE; mooktodo */
tail->next_all = cmdq->head; tail->next_all = cmdq->head;
ASSERT(VALID_ADDRESS(prev));
cmdq->head = prev; cmdq->head = prev;
cmdq = &adapter->cmdq_free; cmdq = &adapter->cmdq_free;
spin_lock_irqsave(&cmdq->lock.lock, cmdq->lock.flags); spin_lock_irqsave(&cmdq->lock.lock, cmdq->lock.flags);
cmdq->count += cmdcnt; /* SLIC_CMDQ_CMDSINPAGE; mooktodo */ cmdq->count += cmdcnt; /* SLIC_CMDQ_CMDSINPAGE; mooktodo */
tail->next = cmdq->head; tail->next = cmdq->head;
ASSERT(VALID_ADDRESS(prev));
cmdq->head = prev; cmdq->head = prev;
spin_unlock_irqrestore(&cmdq->lock.lock, cmdq->lock.flags); spin_unlock_irqrestore(&cmdq->lock.lock, cmdq->lock.flags);
} }
...@@ -3869,7 +3867,6 @@ static void slic_cmdq_getdone(struct adapter *adapter) ...@@ -3869,7 +3867,6 @@ static void slic_cmdq_getdone(struct adapter *adapter)
ASSERT(free_cmdq->head == NULL); ASSERT(free_cmdq->head == NULL);
spin_lock_irqsave(&done_cmdq->lock.lock, done_cmdq->lock.flags); spin_lock_irqsave(&done_cmdq->lock.lock, done_cmdq->lock.flags);
ASSERT(VALID_ADDRESS(done_cmdq->head));
free_cmdq->head = done_cmdq->head; free_cmdq->head = done_cmdq->head;
free_cmdq->count = done_cmdq->count; free_cmdq->count = done_cmdq->count;
...@@ -3886,9 +3883,7 @@ static void slic_cmdq_putdone_irq(struct adapter *adapter, ...@@ -3886,9 +3883,7 @@ static void slic_cmdq_putdone_irq(struct adapter *adapter,
spin_lock(&cmdq->lock.lock); spin_lock(&cmdq->lock.lock);
cmd->busy = 0; cmd->busy = 0;
ASSERT(VALID_ADDRESS(cmdq->head));
cmd->next = cmdq->head; cmd->next = cmdq->head;
ASSERT(VALID_ADDRESS(cmd));
cmdq->head = cmd; cmdq->head = cmd;
cmdq->count++; cmdq->count++;
if ((adapter->xmitq_full) && (cmdq->count > 10)) if ((adapter->xmitq_full) && (cmdq->count > 10))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment