Commit 43bab25c authored by Alex Chiang's avatar Alex Chiang Committed by Len Brown

ACPI: processor: change acpi_processor_set_pdc() interface

When calling _PDC, we really only need the handle to the processor
to call the method; we don't look at any other parts of the
struct acpi_processor * given to us.

In the early path, when we walk the namespace, we are given the
handle directly, so just pass it through to acpi_processor_set_pdc()
without stuffing it into a wasteful struct acpi_processor allocated
on the stack each time

This saves 2834 bytes of stack.

Update the interface accordingly.
Signed-off-by: default avatarAlex Chiang <achiang@hp.com>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent b9c2db78
...@@ -763,7 +763,7 @@ static int __cpuinit acpi_processor_add(struct acpi_device *device) ...@@ -763,7 +763,7 @@ static int __cpuinit acpi_processor_add(struct acpi_device *device)
} }
/* _PDC call should be done before doing anything else (if reqd.). */ /* _PDC call should be done before doing anything else (if reqd.). */
acpi_processor_set_pdc(pr); acpi_processor_set_pdc(pr->handle);
#ifdef CONFIG_CPU_FREQ #ifdef CONFIG_CPU_FREQ
acpi_processor_ppc_has_changed(pr, 0); acpi_processor_ppc_has_changed(pr, 0);
......
...@@ -125,7 +125,7 @@ acpi_processor_eval_pdc(acpi_handle handle, struct acpi_object_list *pdc_in) ...@@ -125,7 +125,7 @@ acpi_processor_eval_pdc(acpi_handle handle, struct acpi_object_list *pdc_in)
return status; return status;
} }
void acpi_processor_set_pdc(struct acpi_processor *pr) void acpi_processor_set_pdc(acpi_handle handle)
{ {
struct acpi_object_list *obj_list; struct acpi_object_list *obj_list;
...@@ -136,7 +136,7 @@ void acpi_processor_set_pdc(struct acpi_processor *pr) ...@@ -136,7 +136,7 @@ void acpi_processor_set_pdc(struct acpi_processor *pr)
if (!obj_list) if (!obj_list)
return; return;
acpi_processor_eval_pdc(pr->handle, obj_list); acpi_processor_eval_pdc(handle, obj_list);
kfree(obj_list->pointer->buffer.pointer); kfree(obj_list->pointer->buffer.pointer);
kfree(obj_list->pointer); kfree(obj_list->pointer);
...@@ -147,19 +147,7 @@ EXPORT_SYMBOL_GPL(acpi_processor_set_pdc); ...@@ -147,19 +147,7 @@ EXPORT_SYMBOL_GPL(acpi_processor_set_pdc);
static acpi_status static acpi_status
early_init_pdc(acpi_handle handle, u32 lvl, void *context, void **rv) early_init_pdc(acpi_handle handle, u32 lvl, void *context, void **rv)
{ {
struct acpi_processor pr; acpi_processor_set_pdc(handle);
pr.handle = handle;
/* x86 implementation looks at pr.id to determine some
* CPU capabilites. We can just hard code to 0 since we're
* assuming the CPUs in the system are homogenous and all
* have the same capabilities.
*/
pr.id = 0;
acpi_processor_set_pdc(&pr);
return AE_OK; return AE_OK;
} }
......
...@@ -323,7 +323,7 @@ static inline int acpi_processor_get_bios_limit(int cpu, unsigned int *limit) ...@@ -323,7 +323,7 @@ static inline int acpi_processor_get_bios_limit(int cpu, unsigned int *limit)
#endif /* CONFIG_CPU_FREQ */ #endif /* CONFIG_CPU_FREQ */
/* in processor_pdc.c */ /* in processor_pdc.c */
void acpi_processor_set_pdc(struct acpi_processor *pr); void acpi_processor_set_pdc(acpi_handle handle);
/* in processor_throttling.c */ /* in processor_throttling.c */
int acpi_processor_tstate_has_changed(struct acpi_processor *pr); int acpi_processor_tstate_has_changed(struct acpi_processor *pr);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment