Commit 40dc5651 authored by Jesper Juhl's avatar Jesper Juhl Committed by Linus Torvalds

[PATCH] cleanup for kernel/printk.c

- Removes some trailing whitespace

- Breaks long lines and make other small changes to conform to CodingStyle

- Add explicit printk loglevels in two places.
Signed-off-by: default avatarJesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 2a91f3e5
...@@ -148,7 +148,7 @@ static int __init console_setup(char *str) ...@@ -148,7 +148,7 @@ static int __init console_setup(char *str)
if (!strcmp(str, "ttyb")) if (!strcmp(str, "ttyb"))
strcpy(name, "ttyS1"); strcpy(name, "ttyS1");
#endif #endif
for(s = name; *s; s++) for (s = name; *s; s++)
if ((*s >= '0' && *s <= '9') || *s == ',') if ((*s >= '0' && *s <= '9') || *s == ',')
break; break;
idx = simple_strtoul(s, NULL, 10); idx = simple_strtoul(s, NULL, 10);
...@@ -169,11 +169,11 @@ static int __init log_buf_len_setup(char *str) ...@@ -169,11 +169,11 @@ static int __init log_buf_len_setup(char *str)
size = roundup_pow_of_two(size); size = roundup_pow_of_two(size);
if (size > log_buf_len) { if (size > log_buf_len) {
unsigned long start, dest_idx, offset; unsigned long start, dest_idx, offset;
char * new_log_buf; char *new_log_buf;
new_log_buf = alloc_bootmem(size); new_log_buf = alloc_bootmem(size);
if (!new_log_buf) { if (!new_log_buf) {
printk("log_buf_len: allocation failed\n"); printk(KERN_WARNING "log_buf_len: allocation failed\n");
goto out; goto out;
} }
...@@ -193,10 +193,9 @@ static int __init log_buf_len_setup(char *str) ...@@ -193,10 +193,9 @@ static int __init log_buf_len_setup(char *str)
log_end -= offset; log_end -= offset;
spin_unlock_irqrestore(&logbuf_lock, flags); spin_unlock_irqrestore(&logbuf_lock, flags);
printk("log_buf_len: %d\n", log_buf_len); printk(KERN_NOTICE "log_buf_len: %d\n", log_buf_len);
} }
out: out:
return 1; return 1;
} }
...@@ -217,7 +216,7 @@ __setup("log_buf_len=", log_buf_len_setup); ...@@ -217,7 +216,7 @@ __setup("log_buf_len=", log_buf_len_setup);
* 9 -- Return number of unread characters in the log buffer * 9 -- Return number of unread characters in the log buffer
* 10 -- Return size of the log buffer * 10 -- Return size of the log buffer
*/ */
int do_syslog(int type, char __user * buf, int len) int do_syslog(int type, char __user *buf, int len)
{ {
unsigned long i, j, limit, count; unsigned long i, j, limit, count;
int do_clear = 0; int do_clear = 0;
...@@ -244,7 +243,8 @@ int do_syslog(int type, char __user * buf, int len) ...@@ -244,7 +243,8 @@ int do_syslog(int type, char __user * buf, int len)
error = -EFAULT; error = -EFAULT;
goto out; goto out;
} }
error = wait_event_interruptible(log_wait, (log_start - log_end)); error = wait_event_interruptible(log_wait,
(log_start - log_end));
if (error) if (error)
goto out; goto out;
i = 0; i = 0;
...@@ -292,7 +292,7 @@ int do_syslog(int type, char __user * buf, int len) ...@@ -292,7 +292,7 @@ int do_syslog(int type, char __user * buf, int len)
* we try to copy to user space. Therefore * we try to copy to user space. Therefore
* the messages are copied in reverse. <manfreds> * the messages are copied in reverse. <manfreds>
*/ */
for(i = 0; i < count && !error; i++) { for (i = 0; i < count && !error; i++) {
j = limit-1-i; j = limit-1-i;
if (j + log_buf_len < log_end) if (j + log_buf_len < log_end)
break; break;
...@@ -306,10 +306,10 @@ int do_syslog(int type, char __user * buf, int len) ...@@ -306,10 +306,10 @@ int do_syslog(int type, char __user * buf, int len)
if (error) if (error)
break; break;
error = i; error = i;
if(i != count) { if (i != count) {
int offset = count-error; int offset = count-error;
/* buffer overflow during copy, correct user buffer. */ /* buffer overflow during copy, correct user buffer. */
for(i=0;i<error;i++) { for (i = 0; i < error; i++) {
if (__get_user(c,&buf[i+offset]) || if (__get_user(c,&buf[i+offset]) ||
__put_user(c,&buf[i])) { __put_user(c,&buf[i])) {
error = -EFAULT; error = -EFAULT;
...@@ -351,7 +351,7 @@ out: ...@@ -351,7 +351,7 @@ out:
return error; return error;
} }
asmlinkage long sys_syslog(int type, char __user * buf, int len) asmlinkage long sys_syslog(int type, char __user *buf, int len)
{ {
return do_syslog(type, buf, len); return do_syslog(type, buf, len);
} }
...@@ -404,21 +404,19 @@ static void call_console_drivers(unsigned long start, unsigned long end) ...@@ -404,21 +404,19 @@ static void call_console_drivers(unsigned long start, unsigned long end)
cur_index = start; cur_index = start;
start_print = start; start_print = start;
while (cur_index != end) { while (cur_index != end) {
if ( msg_level < 0 && if (msg_level < 0 && ((end - cur_index) > 2) &&
((end - cur_index) > 2) &&
LOG_BUF(cur_index + 0) == '<' && LOG_BUF(cur_index + 0) == '<' &&
LOG_BUF(cur_index + 1) >= '0' && LOG_BUF(cur_index + 1) >= '0' &&
LOG_BUF(cur_index + 1) <= '7' && LOG_BUF(cur_index + 1) <= '7' &&
LOG_BUF(cur_index + 2) == '>') LOG_BUF(cur_index + 2) == '>') {
{
msg_level = LOG_BUF(cur_index + 1) - '0'; msg_level = LOG_BUF(cur_index + 1) - '0';
cur_index += 3; cur_index += 3;
start_print = cur_index; start_print = cur_index;
} }
while (cur_index != end) { while (cur_index != end) {
char c = LOG_BUF(cur_index); char c = LOG_BUF(cur_index);
cur_index++;
cur_index++;
if (c == '\n') { if (c == '\n') {
if (msg_level < 0) { if (msg_level < 0) {
/* /*
...@@ -461,7 +459,7 @@ static void zap_locks(void) ...@@ -461,7 +459,7 @@ static void zap_locks(void)
static unsigned long oops_timestamp; static unsigned long oops_timestamp;
if (time_after_eq(jiffies, oops_timestamp) && if (time_after_eq(jiffies, oops_timestamp) &&
!time_after(jiffies, oops_timestamp + 30*HZ)) !time_after(jiffies, oops_timestamp + 30 * HZ))
return; return;
oops_timestamp = jiffies; oops_timestamp = jiffies;
...@@ -639,13 +637,19 @@ EXPORT_SYMBOL(vprintk); ...@@ -639,13 +637,19 @@ EXPORT_SYMBOL(vprintk);
#else #else
asmlinkage long sys_syslog(int type, char __user * buf, int len) asmlinkage long sys_syslog(int type, char __user *buf, int len)
{ {
return 0; return 0;
} }
int do_syslog(int type, char __user * buf, int len) { return 0; } int do_syslog(int type, char __user *buf, int len)
static void call_console_drivers(unsigned long start, unsigned long end) {} {
return 0;
}
static void call_console_drivers(unsigned long start, unsigned long end)
{
}
#endif #endif
...@@ -851,7 +855,7 @@ EXPORT_SYMBOL(console_start); ...@@ -851,7 +855,7 @@ EXPORT_SYMBOL(console_start);
* print any messages that were printed by the kernel before the * print any messages that were printed by the kernel before the
* console driver was initialized. * console driver was initialized.
*/ */
void register_console(struct console * console) void register_console(struct console *console)
{ {
int i; int i;
unsigned long flags; unsigned long flags;
...@@ -878,7 +882,8 @@ void register_console(struct console * console) ...@@ -878,7 +882,8 @@ void register_console(struct console * console)
* See if this console matches one we selected on * See if this console matches one we selected on
* the command line. * the command line.
*/ */
for(i = 0; i < MAX_CMDLINECONSOLES && console_cmdline[i].name[0]; i++) { for (i = 0; i < MAX_CMDLINECONSOLES && console_cmdline[i].name[0];
i++) {
if (strcmp(console_cmdline[i].name, console->name) != 0) if (strcmp(console_cmdline[i].name, console->name) != 0)
continue; continue;
if (console->index >= 0 && if (console->index >= 0 &&
...@@ -933,9 +938,9 @@ void register_console(struct console * console) ...@@ -933,9 +938,9 @@ void register_console(struct console * console)
} }
EXPORT_SYMBOL(register_console); EXPORT_SYMBOL(register_console);
int unregister_console(struct console * console) int unregister_console(struct console *console)
{ {
struct console *a,*b; struct console *a, *b;
int res = 1; int res = 1;
acquire_console_sem(); acquire_console_sem();
...@@ -994,7 +999,7 @@ void tty_write_message(struct tty_struct *tty, char *msg) ...@@ -994,7 +999,7 @@ void tty_write_message(struct tty_struct *tty, char *msg)
int __printk_ratelimit(int ratelimit_jiffies, int ratelimit_burst) int __printk_ratelimit(int ratelimit_jiffies, int ratelimit_burst)
{ {
static DEFINE_SPINLOCK(ratelimit_lock); static DEFINE_SPINLOCK(ratelimit_lock);
static unsigned long toks = 10*5*HZ; static unsigned long toks = 10 * 5 * HZ;
static unsigned long last_msg; static unsigned long last_msg;
static int missed; static int missed;
unsigned long flags; unsigned long flags;
...@@ -1007,6 +1012,7 @@ int __printk_ratelimit(int ratelimit_jiffies, int ratelimit_burst) ...@@ -1007,6 +1012,7 @@ int __printk_ratelimit(int ratelimit_jiffies, int ratelimit_burst)
toks = ratelimit_burst * ratelimit_jiffies; toks = ratelimit_burst * ratelimit_jiffies;
if (toks >= ratelimit_jiffies) { if (toks >= ratelimit_jiffies) {
int lost = missed; int lost = missed;
missed = 0; missed = 0;
toks -= ratelimit_jiffies; toks -= ratelimit_jiffies;
spin_unlock_irqrestore(&ratelimit_lock, flags); spin_unlock_irqrestore(&ratelimit_lock, flags);
...@@ -1021,7 +1027,7 @@ int __printk_ratelimit(int ratelimit_jiffies, int ratelimit_burst) ...@@ -1021,7 +1027,7 @@ int __printk_ratelimit(int ratelimit_jiffies, int ratelimit_burst)
EXPORT_SYMBOL(__printk_ratelimit); EXPORT_SYMBOL(__printk_ratelimit);
/* minimum time in jiffies between messages */ /* minimum time in jiffies between messages */
int printk_ratelimit_jiffies = 5*HZ; int printk_ratelimit_jiffies = 5 * HZ;
/* number of messages we send before ratelimiting */ /* number of messages we send before ratelimiting */
int printk_ratelimit_burst = 10; int printk_ratelimit_burst = 10;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment