Commit 3e9c83b3 authored by Andreas Herrmann's avatar Andreas Herrmann Committed by Ingo Molnar

x86: pat.c consolidate error/debug messages in reserve_memtype

... and move last debug message out of locked section.
Signed-off-by: default avatarAndreas Herrmann <andreas.herrmann3@amd.com>
Cc: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Suresh B Siddha <suresh.b.siddha@intel.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 69e26be9
...@@ -269,12 +269,6 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type, ...@@ -269,12 +269,6 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type,
} }
if (actual_type != entry->type) { if (actual_type != entry->type) {
printk(
KERN_INFO "%s:%d conflicting memory types %Lx-%Lx %s<->%s\n",
current->comm, current->pid,
start, end,
cattr_name(actual_type),
cattr_name(entry->type));
err = -EBUSY; err = -EBUSY;
break; break;
} }
...@@ -290,12 +284,6 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type, ...@@ -290,12 +284,6 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type,
} }
if (actual_type != entry->type) { if (actual_type != entry->type) {
printk(
KERN_INFO "%s:%d conflicting memory types %Lx-%Lx %s<->%s\n",
current->comm, current->pid,
start, end,
cattr_name(actual_type),
cattr_name(entry->type));
err = -EBUSY; err = -EBUSY;
break; break;
} }
...@@ -321,12 +309,6 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type, ...@@ -321,12 +309,6 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type,
} }
if (actual_type != entry->type) { if (actual_type != entry->type) {
printk(
KERN_INFO "%s:%d conflicting memory types %Lx-%Lx %s<->%s\n",
current->comm, current->pid,
start, end,
cattr_name(actual_type),
cattr_name(entry->type));
err = -EBUSY; err = -EBUSY;
break; break;
} }
...@@ -342,12 +324,6 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type, ...@@ -342,12 +324,6 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type,
} }
if (actual_type != entry->type) { if (actual_type != entry->type) {
printk(
KERN_INFO "%s:%d conflicting memory types %Lx-%Lx %s<->%s\n",
current->comm, current->pid,
start, end,
cattr_name(actual_type),
cattr_name(entry->type));
err = -EBUSY; err = -EBUSY;
break; break;
} }
...@@ -367,10 +343,12 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type, ...@@ -367,10 +343,12 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type,
} }
if (err) { if (err) {
printk(KERN_INFO printk(KERN_INFO "%s:%d conflicting memory types "
"reserve_memtype failed 0x%Lx-0x%Lx, track %s, req %s\n", "%Lx-%Lx %s<->%s\n", current->comm, current->pid, start,
start, end, cattr_name(new->type), end, cattr_name(new->type), cattr_name(entry->type));
cattr_name(req_type)); printk(KERN_INFO "reserve_memtype failed 0x%Lx-0x%Lx, "
"track %s, req %s\n",
start, end, cattr_name(new->type), cattr_name(req_type));
kfree(new); kfree(new);
spin_unlock(&memtype_lock); spin_unlock(&memtype_lock);
return err; return err;
...@@ -382,19 +360,12 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type, ...@@ -382,19 +360,12 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type,
dprintk("New Entry\n"); dprintk("New Entry\n");
} }
if (new_type) {
dprintk(
"reserve_memtype added 0x%Lx-0x%Lx, track %s, req %s, ret %s\n",
start, end, cattr_name(actual_type),
cattr_name(req_type), cattr_name(*new_type));
} else {
dprintk(
"reserve_memtype added 0x%Lx-0x%Lx, track %s, req %s\n",
start, end, cattr_name(actual_type),
cattr_name(req_type));
}
spin_unlock(&memtype_lock); spin_unlock(&memtype_lock);
dprintk("reserve_memtype added 0x%Lx-0x%Lx, track %s, req %s, ret %s\n",
start, end, cattr_name(new->type), cattr_name(req_type),
new_type ? cattr_name(*new_type) : "-");
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment