Commit 39a37ce1 authored by Dan Carpenter's avatar Dan Carpenter Committed by Joerg Roedel

dma-debug: Cleanup for copy-loop in filter_write()

Earlier in this function we set the last byte of "buf" to NULL so we
always hit the break statement and "i" is never equal to NAME_MAX_LEN.
This patch doesn't change how the driver works but it silences a Smatch
warning and it makes it clearer that we don't write past the end of the
array.
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarJoerg Roedel <joerg.roedel@amd.com>
parent 12ff4bf5
...@@ -570,7 +570,7 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf, ...@@ -570,7 +570,7 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf,
* Now parse out the first token and use it as the name for the * Now parse out the first token and use it as the name for the
* driver to filter for. * driver to filter for.
*/ */
for (i = 0; i < NAME_MAX_LEN; ++i) { for (i = 0; i < NAME_MAX_LEN - 1; ++i) {
current_driver_name[i] = buf[i]; current_driver_name[i] = buf[i];
if (isspace(buf[i]) || buf[i] == ' ' || buf[i] == 0) if (isspace(buf[i]) || buf[i] == ' ' || buf[i] == 0)
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment