Commit 253d3b13 authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman

Staging: go7007: introduce missing kfree

Error handling code following a kmalloc should free the allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,l;
position p1,p2;
expression *ptr != NULL;
@@

(
if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...)) == NULL) S
|
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
)
<... when != x
     when != if (...) { <+...x...+> }
x->f = E
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 41e84789
...@@ -167,6 +167,7 @@ static int write_reg(struct i2c_client *client, u8 reg, u8 value) ...@@ -167,6 +167,7 @@ static int write_reg(struct i2c_client *client, u8 reg, u8 value)
usb = go->hpi_context; usb = go->hpi_context;
if (down_interruptible(&usb->i2c_lock) != 0) { if (down_interruptible(&usb->i2c_lock) != 0) {
printk(KERN_INFO "i2c lock failed\n"); printk(KERN_INFO "i2c lock failed\n");
kfree(buf);
return -EINTR; return -EINTR;
} }
rc = go7007_usb_vendor_request(go, 0x55, dev_addr, rc = go7007_usb_vendor_request(go, 0x55, dev_addr,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment