Commit 22a627ba authored by Roel Kluin's avatar Roel Kluin Committed by Greg Kroah-Hartman

USB: FIX bitfield istl_flip:1, make it unsigned.

istl_flip is a signed bitfield of one bit so it can be -1 or 0.
However in drivers/usb/host/isp1362-hcd.c:1103:

finish_iso_transfers(isp1362_hcd,
	&isp1362_hcd->istl_queue[isp1362_hcd->istl_flip]);

So if isp1362_hcd->istl_flip is set, the 2nd argument becomes
&isp1362_hcd->istl_queue[-1], which is invalid.
Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Acked-by: default avatarMike Frysinger <vapier@gentoo.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 55f49f26
...@@ -534,8 +534,8 @@ struct isp1362_hcd { ...@@ -534,8 +534,8 @@ struct isp1362_hcd {
/* periodic schedule: isochronous */ /* periodic schedule: isochronous */
struct list_head isoc; struct list_head isoc;
int istl_flip:1; unsigned int istl_flip:1;
int irq_active:1; unsigned int irq_active:1;
/* Schedules for the current frame */ /* Schedules for the current frame */
struct isp1362_ep_queue atl_queue; struct isp1362_ep_queue atl_queue;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment