Commit 20ac9437 authored by Eric W. Biederman's avatar Eric W. Biederman Committed by Linus Torvalds

[PATCH] do_SAK: Don't recursively take the tasklist_lock

By calling send_sig do_SAK is recursively taking the
tasklist_lock, which is silly.

In addition I just audited the kernel and this was the only
place where tasklist_lock is taken inside of task_lock.

So this one line change is a general worthwhile cleanup and
it increases our options on how to fix the ptrace_attach races.
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 907d91d7
...@@ -2734,7 +2734,7 @@ static void __do_SAK(void *arg) ...@@ -2734,7 +2734,7 @@ static void __do_SAK(void *arg)
printk(KERN_NOTICE "SAK: killed process %d" printk(KERN_NOTICE "SAK: killed process %d"
" (%s): fd#%d opened to the tty\n", " (%s): fd#%d opened to the tty\n",
p->pid, p->comm, i); p->pid, p->comm, i);
send_sig(SIGKILL, p, 1); force_sig(SIGKILL, p);
break; break;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment