Commit 132adf54 authored by Stephen Hemminger's avatar Stephen Hemminger Committed by David S. Miller

[IPV4]: cleanup

Add whitespace around keywords.
Signed-off-by: default avatarStephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1ac58ee3
...@@ -1339,7 +1339,7 @@ static int __init inet_init(void) ...@@ -1339,7 +1339,7 @@ static int __init inet_init(void)
* Initialise per-cpu ipv4 mibs * Initialise per-cpu ipv4 mibs
*/ */
if(init_ipv4_mibs()) if (init_ipv4_mibs())
printk(KERN_CRIT "inet_init: Cannot init ipv4 mibs\n"); ; printk(KERN_CRIT "inet_init: Cannot init ipv4 mibs\n"); ;
ipv4_proc_init(); ipv4_proc_init();
......
...@@ -1178,7 +1178,7 @@ int arp_ioctl(unsigned int cmd, void __user *arg) ...@@ -1178,7 +1178,7 @@ int arp_ioctl(unsigned int cmd, void __user *arg)
goto out; goto out;
} }
switch(cmd) { switch (cmd) {
case SIOCDARP: case SIOCDARP:
err = arp_req_delete(&r, dev); err = arp_req_delete(&r, dev);
break; break;
......
...@@ -1174,7 +1174,7 @@ static int cipso_v4_map_cat_rng_ntoh(const struct cipso_v4_doi *doi_def, ...@@ -1174,7 +1174,7 @@ static int cipso_v4_map_cat_rng_ntoh(const struct cipso_v4_doi *doi_def,
u16 cat_low; u16 cat_low;
u16 cat_high; u16 cat_high;
for(net_iter = 0; net_iter < net_cat_len; net_iter += 4) { for (net_iter = 0; net_iter < net_cat_len; net_iter += 4) {
cat_high = ntohs(*((__be16 *)&net_cat[net_iter])); cat_high = ntohs(*((__be16 *)&net_cat[net_iter]));
if ((net_iter + 4) <= net_cat_len) if ((net_iter + 4) <= net_cat_len)
cat_low = ntohs(*((__be16 *)&net_cat[net_iter + 2])); cat_low = ntohs(*((__be16 *)&net_cat[net_iter + 2]));
......
...@@ -633,7 +633,7 @@ int devinet_ioctl(unsigned int cmd, void __user *arg) ...@@ -633,7 +633,7 @@ int devinet_ioctl(unsigned int cmd, void __user *arg)
dev_load(ifr.ifr_name); dev_load(ifr.ifr_name);
#endif #endif
switch(cmd) { switch (cmd) {
case SIOCGIFADDR: /* Get interface address */ case SIOCGIFADDR: /* Get interface address */
case SIOCGIFBRDADDR: /* Get the broadcast address */ case SIOCGIFBRDADDR: /* Get the broadcast address */
case SIOCGIFDSTADDR: /* Get the destination address */ case SIOCGIFDSTADDR: /* Get the destination address */
...@@ -708,7 +708,7 @@ int devinet_ioctl(unsigned int cmd, void __user *arg) ...@@ -708,7 +708,7 @@ int devinet_ioctl(unsigned int cmd, void __user *arg)
if (!ifa && cmd != SIOCSIFADDR && cmd != SIOCSIFFLAGS) if (!ifa && cmd != SIOCSIFADDR && cmd != SIOCSIFFLAGS)
goto done; goto done;
switch(cmd) { switch (cmd) {
case SIOCGIFADDR: /* Get interface address */ case SIOCGIFADDR: /* Get interface address */
sin->sin_addr.s_addr = ifa->ifa_local; sin->sin_addr.s_addr = ifa->ifa_local;
goto rarok; goto rarok;
......
...@@ -350,11 +350,10 @@ static void __tnode_free_rcu(struct rcu_head *head) ...@@ -350,11 +350,10 @@ static void __tnode_free_rcu(struct rcu_head *head)
static inline void tnode_free(struct tnode *tn) static inline void tnode_free(struct tnode *tn)
{ {
if(IS_LEAF(tn)) { if (IS_LEAF(tn)) {
struct leaf *l = (struct leaf *) tn; struct leaf *l = (struct leaf *) tn;
call_rcu_bh(&l->rcu, __leaf_free_rcu); call_rcu_bh(&l->rcu, __leaf_free_rcu);
} } else
else
call_rcu(&tn->rcu, __tnode_free_rcu); call_rcu(&tn->rcu, __tnode_free_rcu);
} }
...@@ -553,7 +552,7 @@ static struct node *resize(struct trie *t, struct tnode *tn) ...@@ -553,7 +552,7 @@ static struct node *resize(struct trie *t, struct tnode *tn)
/* Keep root node larger */ /* Keep root node larger */
if(!tn->parent) if (!tn->parent)
inflate_threshold_use = inflate_threshold_root; inflate_threshold_use = inflate_threshold_root;
else else
inflate_threshold_use = inflate_threshold; inflate_threshold_use = inflate_threshold;
...@@ -584,7 +583,7 @@ static struct node *resize(struct trie *t, struct tnode *tn) ...@@ -584,7 +583,7 @@ static struct node *resize(struct trie *t, struct tnode *tn)
/* Keep root node larger */ /* Keep root node larger */
if(!tn->parent) if (!tn->parent)
halve_threshold_use = halve_threshold_root; halve_threshold_use = halve_threshold_root;
else else
halve_threshold_use = halve_threshold; halve_threshold_use = halve_threshold;
...@@ -2039,12 +2038,12 @@ static struct node *fib_trie_get_first(struct fib_trie_iter *iter, ...@@ -2039,12 +2038,12 @@ static struct node *fib_trie_get_first(struct fib_trie_iter *iter,
{ {
struct node *n ; struct node *n ;
if(!t) if (!t)
return NULL; return NULL;
n = rcu_dereference(t->trie); n = rcu_dereference(t->trie);
if(!iter) if (!iter)
return NULL; return NULL;
if (n) { if (n) {
...@@ -2084,7 +2083,7 @@ static void trie_collect_stats(struct trie *t, struct trie_stat *s) ...@@ -2084,7 +2083,7 @@ static void trie_collect_stats(struct trie *t, struct trie_stat *s)
int i; int i;
s->tnodes++; s->tnodes++;
if(tn->bits < MAX_STAT_DEPTH) if (tn->bits < MAX_STAT_DEPTH)
s->nodesizes[tn->bits]++; s->nodesizes[tn->bits]++;
for (i = 0; i < (1<<tn->bits); i++) for (i = 0; i < (1<<tn->bits); i++)
...@@ -2250,7 +2249,7 @@ static inline const char *rtn_scope(enum rt_scope_t s) ...@@ -2250,7 +2249,7 @@ static inline const char *rtn_scope(enum rt_scope_t s)
{ {
static char buf[32]; static char buf[32];
switch(s) { switch (s) {
case RT_SCOPE_UNIVERSE: return "universe"; case RT_SCOPE_UNIVERSE: return "universe";
case RT_SCOPE_SITE: return "site"; case RT_SCOPE_SITE: return "site";
case RT_SCOPE_LINK: return "link"; case RT_SCOPE_LINK: return "link";
......
...@@ -184,7 +184,7 @@ static __inline__ struct ipq *frag_alloc_queue(void) ...@@ -184,7 +184,7 @@ static __inline__ struct ipq *frag_alloc_queue(void)
{ {
struct ipq *qp = kmalloc(sizeof(struct ipq), GFP_ATOMIC); struct ipq *qp = kmalloc(sizeof(struct ipq), GFP_ATOMIC);
if(!qp) if (!qp)
return NULL; return NULL;
atomic_add(sizeof(struct ipq), &ip_frag_mem); atomic_add(sizeof(struct ipq), &ip_frag_mem);
return qp; return qp;
...@@ -321,7 +321,7 @@ static struct ipq *ip_frag_intern(struct ipq *qp_in) ...@@ -321,7 +321,7 @@ static struct ipq *ip_frag_intern(struct ipq *qp_in)
* promoted read lock to write lock. * promoted read lock to write lock.
*/ */
hlist_for_each_entry(qp, n, &ipq_hash[hash], list) { hlist_for_each_entry(qp, n, &ipq_hash[hash], list) {
if(qp->id == qp_in->id && if (qp->id == qp_in->id &&
qp->saddr == qp_in->saddr && qp->saddr == qp_in->saddr &&
qp->daddr == qp_in->daddr && qp->daddr == qp_in->daddr &&
qp->protocol == qp_in->protocol && qp->protocol == qp_in->protocol &&
...@@ -398,7 +398,7 @@ static inline struct ipq *ip_find(struct iphdr *iph, u32 user) ...@@ -398,7 +398,7 @@ static inline struct ipq *ip_find(struct iphdr *iph, u32 user)
read_lock(&ipfrag_lock); read_lock(&ipfrag_lock);
hash = ipqhashfn(id, saddr, daddr, protocol); hash = ipqhashfn(id, saddr, daddr, protocol);
hlist_for_each_entry(qp, n, &ipq_hash[hash], list) { hlist_for_each_entry(qp, n, &ipq_hash[hash], list) {
if(qp->id == id && if (qp->id == id &&
qp->saddr == saddr && qp->saddr == saddr &&
qp->daddr == daddr && qp->daddr == daddr &&
qp->protocol == protocol && qp->protocol == protocol &&
...@@ -524,7 +524,7 @@ static void ip_frag_queue(struct ipq *qp, struct sk_buff *skb) ...@@ -524,7 +524,7 @@ static void ip_frag_queue(struct ipq *qp, struct sk_buff *skb)
* this fragment, right? * this fragment, right?
*/ */
prev = NULL; prev = NULL;
for(next = qp->fragments; next != NULL; next = next->next) { for (next = qp->fragments; next != NULL; next = next->next) {
if (FRAG_CB(next)->offset >= offset) if (FRAG_CB(next)->offset >= offset)
break; /* bingo! */ break; /* bingo! */
prev = next; prev = next;
...@@ -627,7 +627,7 @@ static struct sk_buff *ip_frag_reasm(struct ipq *qp, struct net_device *dev) ...@@ -627,7 +627,7 @@ static struct sk_buff *ip_frag_reasm(struct ipq *qp, struct net_device *dev)
ihlen = head->nh.iph->ihl*4; ihlen = head->nh.iph->ihl*4;
len = ihlen + qp->len; len = ihlen + qp->len;
if(len > 65535) if (len > 65535)
goto out_oversize; goto out_oversize;
/* Head of list must not be cloned. */ /* Head of list must not be cloned. */
......
...@@ -566,7 +566,7 @@ slow_path: ...@@ -566,7 +566,7 @@ slow_path:
* Keep copying data until we run out. * Keep copying data until we run out.
*/ */
while(left > 0) { while (left > 0) {
len = left; len = left;
/* IF: it doesn't fit, use 'mtu' - the data space left */ /* IF: it doesn't fit, use 'mtu' - the data space left */
if (len > mtu) if (len > mtu)
......
...@@ -623,7 +623,7 @@ static int do_ip_setsockopt(struct sock *sk, int level, ...@@ -623,7 +623,7 @@ static int do_ip_setsockopt(struct sock *sk, int level,
goto e_inval; goto e_inval;
err = -EFAULT; err = -EFAULT;
if (optlen >= sizeof(struct ip_mreqn)) { if (optlen >= sizeof(struct ip_mreqn)) {
if(copy_from_user(&mreq,optval,sizeof(mreq))) if (copy_from_user(&mreq,optval,sizeof(mreq)))
break; break;
} else { } else {
memset(&mreq, 0, sizeof(mreq)); memset(&mreq, 0, sizeof(mreq));
...@@ -722,7 +722,7 @@ static int do_ip_setsockopt(struct sock *sk, int level, ...@@ -722,7 +722,7 @@ static int do_ip_setsockopt(struct sock *sk, int level,
if (optlen < sizeof(struct group_req)) if (optlen < sizeof(struct group_req))
goto e_inval; goto e_inval;
err = -EFAULT; err = -EFAULT;
if(copy_from_user(&greq, optval, sizeof(greq))) if (copy_from_user(&greq, optval, sizeof(greq)))
break; break;
psin = (struct sockaddr_in *)&greq.gr_group; psin = (struct sockaddr_in *)&greq.gr_group;
if (psin->sin_family != AF_INET) if (psin->sin_family != AF_INET)
...@@ -852,7 +852,7 @@ static int do_ip_setsockopt(struct sock *sk, int level, ...@@ -852,7 +852,7 @@ static int do_ip_setsockopt(struct sock *sk, int level,
gsf = NULL; gsf = NULL;
err = ip_mc_msfilter(sk, msf, ifindex); err = ip_mc_msfilter(sk, msf, ifindex);
mc_msf_out: mc_msf_out:
kfree(msf); kfree(msf);
kfree(gsf); kfree(gsf);
break; break;
...@@ -954,24 +954,23 @@ static int do_ip_getsockopt(struct sock *sk, int level, int optname, ...@@ -954,24 +954,23 @@ static int do_ip_getsockopt(struct sock *sk, int level, int optname,
int val; int val;
int len; int len;
if(level!=SOL_IP) if (level != SOL_IP)
return -EOPNOTSUPP; return -EOPNOTSUPP;
#ifdef CONFIG_IP_MROUTE #ifdef CONFIG_IP_MROUTE
if(optname>=MRT_BASE && optname <=MRT_BASE+10) if (optname >= MRT_BASE && optname <= MRT_BASE+10) {
{
return ip_mroute_getsockopt(sk,optname,optval,optlen); return ip_mroute_getsockopt(sk,optname,optval,optlen);
} }
#endif #endif
if(get_user(len,optlen)) if (get_user(len,optlen))
return -EFAULT; return -EFAULT;
if(len < 0) if (len < 0)
return -EINVAL; return -EINVAL;
lock_sock(sk); lock_sock(sk);
switch(optname) { switch (optname) {
case IP_OPTIONS: case IP_OPTIONS:
{ {
unsigned char optbuf[sizeof(struct ip_options)+40]; unsigned char optbuf[sizeof(struct ip_options)+40];
...@@ -989,9 +988,9 @@ static int do_ip_getsockopt(struct sock *sk, int level, int optname, ...@@ -989,9 +988,9 @@ static int do_ip_getsockopt(struct sock *sk, int level, int optname,
ip_options_undo(opt); ip_options_undo(opt);
len = min_t(unsigned int, len, opt->optlen); len = min_t(unsigned int, len, opt->optlen);
if(put_user(len, optlen)) if (put_user(len, optlen))
return -EFAULT; return -EFAULT;
if(copy_to_user(optval, opt->__data, len)) if (copy_to_user(optval, opt->__data, len))
return -EFAULT; return -EFAULT;
return 0; return 0;
} }
...@@ -1058,9 +1057,9 @@ static int do_ip_getsockopt(struct sock *sk, int level, int optname, ...@@ -1058,9 +1057,9 @@ static int do_ip_getsockopt(struct sock *sk, int level, int optname,
addr.s_addr = inet->mc_addr; addr.s_addr = inet->mc_addr;
release_sock(sk); release_sock(sk);
if(put_user(len, optlen)) if (put_user(len, optlen))
return -EFAULT; return -EFAULT;
if(copy_to_user(optval, &addr, len)) if (copy_to_user(optval, &addr, len))
return -EFAULT; return -EFAULT;
return 0; return 0;
} }
...@@ -1140,15 +1139,15 @@ static int do_ip_getsockopt(struct sock *sk, int level, int optname, ...@@ -1140,15 +1139,15 @@ static int do_ip_getsockopt(struct sock *sk, int level, int optname,
if (len < sizeof(int) && len > 0 && val>=0 && val<255) { if (len < sizeof(int) && len > 0 && val>=0 && val<255) {
unsigned char ucval = (unsigned char)val; unsigned char ucval = (unsigned char)val;
len = 1; len = 1;
if(put_user(len, optlen)) if (put_user(len, optlen))
return -EFAULT; return -EFAULT;
if(copy_to_user(optval,&ucval,1)) if (copy_to_user(optval,&ucval,1))
return -EFAULT; return -EFAULT;
} else { } else {
len = min_t(unsigned int, sizeof(int), len); len = min_t(unsigned int, sizeof(int), len);
if(put_user(len, optlen)) if (put_user(len, optlen))
return -EFAULT; return -EFAULT;
if(copy_to_user(optval,&val,len)) if (copy_to_user(optval,&val,len))
return -EFAULT; return -EFAULT;
} }
return 0; return 0;
...@@ -1169,7 +1168,7 @@ int ip_getsockopt(struct sock *sk, int level, ...@@ -1169,7 +1168,7 @@ int ip_getsockopt(struct sock *sk, int level,
) { ) {
int len; int len;
if(get_user(len,optlen)) if (get_user(len,optlen))
return -EFAULT; return -EFAULT;
lock_sock(sk); lock_sock(sk);
......
...@@ -782,7 +782,7 @@ static void __init ic_do_bootp_ext(u8 *ext) ...@@ -782,7 +782,7 @@ static void __init ic_do_bootp_ext(u8 *ext)
u8 *c; u8 *c;
printk("DHCP/BOOTP: Got extension %d:",*ext); printk("DHCP/BOOTP: Got extension %d:",*ext);
for(c=ext+2; c<ext+2+ext[1]; c++) for (c=ext+2; c<ext+2+ext[1]; c++)
printk(" %02x", *c); printk(" %02x", *c);
printk("\n"); printk("\n");
#endif #endif
...@@ -1094,7 +1094,7 @@ static int __init ic_dynamic(void) ...@@ -1094,7 +1094,7 @@ static int __init ic_dynamic(void)
retries = CONF_SEND_RETRIES; retries = CONF_SEND_RETRIES;
get_random_bytes(&timeout, sizeof(timeout)); get_random_bytes(&timeout, sizeof(timeout));
timeout = CONF_BASE_TIMEOUT + (timeout % (unsigned) CONF_TIMEOUT_RANDOM); timeout = CONF_BASE_TIMEOUT + (timeout % (unsigned) CONF_TIMEOUT_RANDOM);
for(;;) { for (;;) {
#ifdef IPCONFIG_BOOTP #ifdef IPCONFIG_BOOTP
if (do_bootp && (d->able & IC_BOOTP)) if (do_bootp && (d->able & IC_BOOTP))
ic_bootp_send_if(d, jiffies - start_jiffies); ic_bootp_send_if(d, jiffies - start_jiffies);
......
...@@ -302,7 +302,7 @@ static void ipmr_destroy_unres(struct mfc_cache *c) ...@@ -302,7 +302,7 @@ static void ipmr_destroy_unres(struct mfc_cache *c)
atomic_dec(&cache_resolve_queue_len); atomic_dec(&cache_resolve_queue_len);
while((skb=skb_dequeue(&c->mfc_un.unres.unresolved))) { while ((skb=skb_dequeue(&c->mfc_un.unres.unresolved))) {
if (skb->nh.iph->version == 0) { if (skb->nh.iph->version == 0) {
struct nlmsghdr *nlh = (struct nlmsghdr *)skb_pull(skb, sizeof(struct iphdr)); struct nlmsghdr *nlh = (struct nlmsghdr *)skb_pull(skb, sizeof(struct iphdr));
nlh->nlmsg_type = NLMSG_ERROR; nlh->nlmsg_type = NLMSG_ERROR;
...@@ -479,7 +479,7 @@ static struct mfc_cache *ipmr_cache_find(__be32 origin, __be32 mcastgrp) ...@@ -479,7 +479,7 @@ static struct mfc_cache *ipmr_cache_find(__be32 origin, __be32 mcastgrp)
static struct mfc_cache *ipmr_cache_alloc(void) static struct mfc_cache *ipmr_cache_alloc(void)
{ {
struct mfc_cache *c=kmem_cache_zalloc(mrt_cachep, GFP_KERNEL); struct mfc_cache *c=kmem_cache_zalloc(mrt_cachep, GFP_KERNEL);
if(c==NULL) if (c==NULL)
return NULL; return NULL;
c->mfc_un.res.minvif = MAXVIFS; c->mfc_un.res.minvif = MAXVIFS;
return c; return c;
...@@ -488,7 +488,7 @@ static struct mfc_cache *ipmr_cache_alloc(void) ...@@ -488,7 +488,7 @@ static struct mfc_cache *ipmr_cache_alloc(void)
static struct mfc_cache *ipmr_cache_alloc_unres(void) static struct mfc_cache *ipmr_cache_alloc_unres(void)
{ {
struct mfc_cache *c=kmem_cache_zalloc(mrt_cachep, GFP_ATOMIC); struct mfc_cache *c=kmem_cache_zalloc(mrt_cachep, GFP_ATOMIC);
if(c==NULL) if (c==NULL)
return NULL; return NULL;
skb_queue_head_init(&c->mfc_un.unres.unresolved); skb_queue_head_init(&c->mfc_un.unres.unresolved);
c->mfc_un.unres.expires = jiffies + 10*HZ; c->mfc_un.unres.expires = jiffies + 10*HZ;
...@@ -508,7 +508,7 @@ static void ipmr_cache_resolve(struct mfc_cache *uc, struct mfc_cache *c) ...@@ -508,7 +508,7 @@ static void ipmr_cache_resolve(struct mfc_cache *uc, struct mfc_cache *c)
* Play the pending entries through our router * Play the pending entries through our router
*/ */
while((skb=__skb_dequeue(&uc->mfc_un.unres.unresolved))) { while ((skb=__skb_dequeue(&uc->mfc_un.unres.unresolved))) {
if (skb->nh.iph->version == 0) { if (skb->nh.iph->version == 0) {
struct nlmsghdr *nlh = (struct nlmsghdr *)skb_pull(skb, sizeof(struct iphdr)); struct nlmsghdr *nlh = (struct nlmsghdr *)skb_pull(skb, sizeof(struct iphdr));
...@@ -551,7 +551,7 @@ static int ipmr_cache_report(struct sk_buff *pkt, vifi_t vifi, int assert) ...@@ -551,7 +551,7 @@ static int ipmr_cache_report(struct sk_buff *pkt, vifi_t vifi, int assert)
#endif #endif
skb = alloc_skb(128, GFP_ATOMIC); skb = alloc_skb(128, GFP_ATOMIC);
if(!skb) if (!skb)
return -ENOBUFS; return -ENOBUFS;
#ifdef CONFIG_IP_PIMSM #ifdef CONFIG_IP_PIMSM
...@@ -734,7 +734,7 @@ static int ipmr_mfc_add(struct mfcctl *mfc, int mrtsock) ...@@ -734,7 +734,7 @@ static int ipmr_mfc_add(struct mfcctl *mfc, int mrtsock)
return 0; return 0;
} }
if(!MULTICAST(mfc->mfcc_mcastgrp.s_addr)) if (!MULTICAST(mfc->mfcc_mcastgrp.s_addr))
return -EINVAL; return -EINVAL;
c=ipmr_cache_alloc(); c=ipmr_cache_alloc();
...@@ -788,7 +788,7 @@ static void mroute_clean_tables(struct sock *sk) ...@@ -788,7 +788,7 @@ static void mroute_clean_tables(struct sock *sk)
/* /*
* Shut down all active vif entries * Shut down all active vif entries
*/ */
for(i=0; i<maxvif; i++) { for (i=0; i<maxvif; i++) {
if (!(vif_table[i].flags&VIFF_STATIC)) if (!(vif_table[i].flags&VIFF_STATIC))
vif_delete(i); vif_delete(i);
} }
...@@ -858,19 +858,17 @@ int ip_mroute_setsockopt(struct sock *sk,int optname,char __user *optval,int opt ...@@ -858,19 +858,17 @@ int ip_mroute_setsockopt(struct sock *sk,int optname,char __user *optval,int opt
struct vifctl vif; struct vifctl vif;
struct mfcctl mfc; struct mfcctl mfc;
if(optname!=MRT_INIT) if (optname != MRT_INIT) {
{ if (sk != mroute_socket && !capable(CAP_NET_ADMIN))
if(sk!=mroute_socket && !capable(CAP_NET_ADMIN))
return -EACCES; return -EACCES;
} }
switch(optname) switch (optname) {
{
case MRT_INIT: case MRT_INIT:
if (sk->sk_type != SOCK_RAW || if (sk->sk_type != SOCK_RAW ||
inet_sk(sk)->num != IPPROTO_IGMP) inet_sk(sk)->num != IPPROTO_IGMP)
return -EOPNOTSUPP; return -EOPNOTSUPP;
if(optlen!=sizeof(int)) if (optlen!=sizeof(int))
return -ENOPROTOOPT; return -ENOPROTOOPT;
rtnl_lock(); rtnl_lock();
...@@ -895,11 +893,11 @@ int ip_mroute_setsockopt(struct sock *sk,int optname,char __user *optval,int opt ...@@ -895,11 +893,11 @@ int ip_mroute_setsockopt(struct sock *sk,int optname,char __user *optval,int opt
return ip_ra_control(sk, 0, NULL); return ip_ra_control(sk, 0, NULL);
case MRT_ADD_VIF: case MRT_ADD_VIF:
case MRT_DEL_VIF: case MRT_DEL_VIF:
if(optlen!=sizeof(vif)) if (optlen!=sizeof(vif))
return -EINVAL; return -EINVAL;
if (copy_from_user(&vif,optval,sizeof(vif))) if (copy_from_user(&vif,optval,sizeof(vif)))
return -EFAULT; return -EFAULT;
if(vif.vifc_vifi >= MAXVIFS) if (vif.vifc_vifi >= MAXVIFS)
return -ENFILE; return -ENFILE;
rtnl_lock(); rtnl_lock();
if (optname==MRT_ADD_VIF) { if (optname==MRT_ADD_VIF) {
...@@ -916,7 +914,7 @@ int ip_mroute_setsockopt(struct sock *sk,int optname,char __user *optval,int opt ...@@ -916,7 +914,7 @@ int ip_mroute_setsockopt(struct sock *sk,int optname,char __user *optval,int opt
*/ */
case MRT_ADD_MFC: case MRT_ADD_MFC:
case MRT_DEL_MFC: case MRT_DEL_MFC:
if(optlen!=sizeof(mfc)) if (optlen!=sizeof(mfc))
return -EINVAL; return -EINVAL;
if (copy_from_user(&mfc,optval, sizeof(mfc))) if (copy_from_user(&mfc,optval, sizeof(mfc)))
return -EFAULT; return -EFAULT;
...@@ -933,7 +931,7 @@ int ip_mroute_setsockopt(struct sock *sk,int optname,char __user *optval,int opt ...@@ -933,7 +931,7 @@ int ip_mroute_setsockopt(struct sock *sk,int optname,char __user *optval,int opt
case MRT_ASSERT: case MRT_ASSERT:
{ {
int v; int v;
if(get_user(v,(int __user *)optval)) if (get_user(v,(int __user *)optval))
return -EFAULT; return -EFAULT;
mroute_do_assert=(v)?1:0; mroute_do_assert=(v)?1:0;
return 0; return 0;
...@@ -942,7 +940,7 @@ int ip_mroute_setsockopt(struct sock *sk,int optname,char __user *optval,int opt ...@@ -942,7 +940,7 @@ int ip_mroute_setsockopt(struct sock *sk,int optname,char __user *optval,int opt
case MRT_PIM: case MRT_PIM:
{ {
int v, ret; int v, ret;
if(get_user(v,(int __user *)optval)) if (get_user(v,(int __user *)optval))
return -EFAULT; return -EFAULT;
v = (v)?1:0; v = (v)?1:0;
rtnl_lock(); rtnl_lock();
...@@ -983,7 +981,7 @@ int ip_mroute_getsockopt(struct sock *sk,int optname,char __user *optval,int __u ...@@ -983,7 +981,7 @@ int ip_mroute_getsockopt(struct sock *sk,int optname,char __user *optval,int __u
int olr; int olr;
int val; int val;
if(optname!=MRT_VERSION && if (optname!=MRT_VERSION &&
#ifdef CONFIG_IP_PIMSM #ifdef CONFIG_IP_PIMSM
optname!=MRT_PIM && optname!=MRT_PIM &&
#endif #endif
...@@ -997,17 +995,17 @@ int ip_mroute_getsockopt(struct sock *sk,int optname,char __user *optval,int __u ...@@ -997,17 +995,17 @@ int ip_mroute_getsockopt(struct sock *sk,int optname,char __user *optval,int __u
if (olr < 0) if (olr < 0)
return -EINVAL; return -EINVAL;
if(put_user(olr,optlen)) if (put_user(olr,optlen))
return -EFAULT; return -EFAULT;
if(optname==MRT_VERSION) if (optname==MRT_VERSION)
val=0x0305; val=0x0305;
#ifdef CONFIG_IP_PIMSM #ifdef CONFIG_IP_PIMSM
else if(optname==MRT_PIM) else if (optname==MRT_PIM)
val=mroute_do_pim; val=mroute_do_pim;
#endif #endif
else else
val=mroute_do_assert; val=mroute_do_assert;
if(copy_to_user(optval,&val,olr)) if (copy_to_user(optval,&val,olr))
return -EFAULT; return -EFAULT;
return 0; return 0;
} }
...@@ -1023,16 +1021,15 @@ int ipmr_ioctl(struct sock *sk, int cmd, void __user *arg) ...@@ -1023,16 +1021,15 @@ int ipmr_ioctl(struct sock *sk, int cmd, void __user *arg)
struct vif_device *vif; struct vif_device *vif;
struct mfc_cache *c; struct mfc_cache *c;
switch(cmd) switch (cmd) {
{
case SIOCGETVIFCNT: case SIOCGETVIFCNT:
if (copy_from_user(&vr,arg,sizeof(vr))) if (copy_from_user(&vr,arg,sizeof(vr)))
return -EFAULT; return -EFAULT;
if(vr.vifi>=maxvif) if (vr.vifi>=maxvif)
return -EINVAL; return -EINVAL;
read_lock(&mrt_lock); read_lock(&mrt_lock);
vif=&vif_table[vr.vifi]; vif=&vif_table[vr.vifi];
if(VIF_EXISTS(vr.vifi)) { if (VIF_EXISTS(vr.vifi)) {
vr.icount=vif->pkt_in; vr.icount=vif->pkt_in;
vr.ocount=vif->pkt_out; vr.ocount=vif->pkt_out;
vr.ibytes=vif->bytes_in; vr.ibytes=vif->bytes_in;
...@@ -1076,7 +1073,7 @@ static int ipmr_device_event(struct notifier_block *this, unsigned long event, v ...@@ -1076,7 +1073,7 @@ static int ipmr_device_event(struct notifier_block *this, unsigned long event, v
if (event != NETDEV_UNREGISTER) if (event != NETDEV_UNREGISTER)
return NOTIFY_DONE; return NOTIFY_DONE;
v=&vif_table[0]; v=&vif_table[0];
for(ct=0;ct<maxvif;ct++,v++) { for (ct=0;ct<maxvif;ct++,v++) {
if (v->dev==ptr) if (v->dev==ptr)
vif_delete(ct); vif_delete(ct);
} }
...@@ -1625,7 +1622,7 @@ static struct vif_device *ipmr_vif_seq_idx(struct ipmr_vif_iter *iter, ...@@ -1625,7 +1622,7 @@ static struct vif_device *ipmr_vif_seq_idx(struct ipmr_vif_iter *iter,
loff_t pos) loff_t pos)
{ {
for (iter->ct = 0; iter->ct < maxvif; ++iter->ct) { for (iter->ct = 0; iter->ct < maxvif; ++iter->ct) {
if(!VIF_EXISTS(iter->ct)) if (!VIF_EXISTS(iter->ct))
continue; continue;
if (pos-- == 0) if (pos-- == 0)
return &vif_table[iter->ct]; return &vif_table[iter->ct];
...@@ -1649,7 +1646,7 @@ static void *ipmr_vif_seq_next(struct seq_file *seq, void *v, loff_t *pos) ...@@ -1649,7 +1646,7 @@ static void *ipmr_vif_seq_next(struct seq_file *seq, void *v, loff_t *pos)
return ipmr_vif_seq_idx(iter, 0); return ipmr_vif_seq_idx(iter, 0);
while (++iter->ct < maxvif) { while (++iter->ct < maxvif) {
if(!VIF_EXISTS(iter->ct)) if (!VIF_EXISTS(iter->ct))
continue; continue;
return &vif_table[iter->ct]; return &vif_table[iter->ct];
} }
...@@ -1732,14 +1729,14 @@ static struct mfc_cache *ipmr_mfc_seq_idx(struct ipmr_mfc_iter *it, loff_t pos) ...@@ -1732,14 +1729,14 @@ static struct mfc_cache *ipmr_mfc_seq_idx(struct ipmr_mfc_iter *it, loff_t pos)
it->cache = mfc_cache_array; it->cache = mfc_cache_array;
read_lock(&mrt_lock); read_lock(&mrt_lock);
for (it->ct = 0; it->ct < MFC_LINES; it->ct++) for (it->ct = 0; it->ct < MFC_LINES; it->ct++)
for(mfc = mfc_cache_array[it->ct]; mfc; mfc = mfc->next) for (mfc = mfc_cache_array[it->ct]; mfc; mfc = mfc->next)
if (pos-- == 0) if (pos-- == 0)
return mfc; return mfc;
read_unlock(&mrt_lock); read_unlock(&mrt_lock);
it->cache = &mfc_unres_queue; it->cache = &mfc_unres_queue;
spin_lock_bh(&mfc_unres_lock); spin_lock_bh(&mfc_unres_lock);
for(mfc = mfc_unres_queue; mfc; mfc = mfc->next) for (mfc = mfc_unres_queue; mfc; mfc = mfc->next)
if (pos-- == 0) if (pos-- == 0)
return mfc; return mfc;
spin_unlock_bh(&mfc_unres_lock); spin_unlock_bh(&mfc_unres_lock);
...@@ -1829,9 +1826,9 @@ static int ipmr_mfc_seq_show(struct seq_file *seq, void *v) ...@@ -1829,9 +1826,9 @@ static int ipmr_mfc_seq_show(struct seq_file *seq, void *v)
mfc->mfc_un.res.wrong_if); mfc->mfc_un.res.wrong_if);
if (it->cache != &mfc_unres_queue) { if (it->cache != &mfc_unres_queue) {
for(n = mfc->mfc_un.res.minvif; for (n = mfc->mfc_un.res.minvif;
n < mfc->mfc_un.res.maxvif; n++ ) { n < mfc->mfc_un.res.maxvif; n++ ) {
if(VIF_EXISTS(n) if (VIF_EXISTS(n)
&& mfc->mfc_un.res.ttls[n] < 255) && mfc->mfc_un.res.ttls[n] < 255)
seq_printf(seq, seq_printf(seq,
" %2d:%-3d", " %2d:%-3d",
......
...@@ -93,7 +93,7 @@ static int xfrm4_tunnel_input(struct xfrm_state *x, struct sk_buff *skb) ...@@ -93,7 +93,7 @@ static int xfrm4_tunnel_input(struct xfrm_state *x, struct sk_buff *skb)
struct iphdr *iph = skb->nh.iph; struct iphdr *iph = skb->nh.iph;
int err = -EINVAL; int err = -EINVAL;
switch(iph->protocol){ switch (iph->protocol){
case IPPROTO_IPIP: case IPPROTO_IPIP:
break; break;
#if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE) #if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE)
......
...@@ -119,7 +119,7 @@ __xfrm4_bundle_create(struct xfrm_policy *policy, struct xfrm_state **xfrm, int ...@@ -119,7 +119,7 @@ __xfrm4_bundle_create(struct xfrm_policy *policy, struct xfrm_state **xfrm, int
if (xfrm[i]->props.mode == XFRM_MODE_TUNNEL) { if (xfrm[i]->props.mode == XFRM_MODE_TUNNEL) {
unsigned short encap_family = xfrm[i]->props.family; unsigned short encap_family = xfrm[i]->props.family;
switch(encap_family) { switch (encap_family) {
case AF_INET: case AF_INET:
fl_tunnel.fl4_dst = xfrm[i]->id.daddr.a4; fl_tunnel.fl4_dst = xfrm[i]->id.daddr.a4;
fl_tunnel.fl4_src = xfrm[i]->props.saddr.a4; fl_tunnel.fl4_src = xfrm[i]->props.saddr.a4;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment