Commit 11d579ee authored by Wolfram Sang's avatar Wolfram Sang Committed by Grant Likely

powerpc/mpc5200: Fix wrong 'no interrupt' handling in of_i2c

If an I2C device node does not specify an interrupt, the .irq member of the
board_info struct was set to -1. This caused crashes on following
irq_dispose_mappings. Leave it NO_IRQ as returned from irq_of_parse_and_map.
(Suggesting -1 as 'i2c-no-irq' used to be a bug in linux/i2c.h.)
Signed-off-by: default avatarWolfram Sang <w.sang@pengutronix.de>
Acked-by: default avatarSean MacLennan <smaclennan@pikatech.com>
Signed-off-by: default avatarGrant Likely <grant.likely@secretlab.ca>
parent e89970aa
...@@ -91,8 +91,6 @@ void of_register_i2c_devices(struct i2c_adapter *adap, ...@@ -91,8 +91,6 @@ void of_register_i2c_devices(struct i2c_adapter *adap,
} }
info.irq = irq_of_parse_and_map(node, 0); info.irq = irq_of_parse_and_map(node, 0);
if (info.irq == NO_IRQ)
info.irq = -1;
if (of_find_i2c_driver(node, &info) < 0) { if (of_find_i2c_driver(node, &info) < 0) {
irq_dispose_mapping(info.irq); irq_dispose_mapping(info.irq);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment