• Jan Kara's avatar
    ext4: Fix truncation of symlinks after failed write · ffacfa7a
    Jan Kara authored
    Contents of long symlinks is written via standard write methods. So
    when the write fails, we add inode to orphan list. But symlinks don't
    have .truncate method defined so nobody properly removes them from the
    on disk orphan list.
    
    Fix this by calling ext4_truncate() directly instead of calling
    vmtruncate() (which is saner anyway since we don't need anything
    vmtruncate() does except from calling .truncate in these paths).  We
    also add inode to orphan list only if ext4_can_truncate() is true
    (currently, it can be false for symlinks when there are no blocks
    allocated) - otherwise orphan list processing will complain and
    ext4_truncate() will not remove inode from on-disk orphan list.
    Signed-off-by: default avatarJan Kara <jack@suse.cz>
    Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
    ffacfa7a
inode.c 157 KB