• Mikulas Patocka's avatar
    dm table: fix queue_limit checking device iterator · f6a1ed10
    Mikulas Patocka authored
    The logic to check for valid device areas is inverted relative to proper
    use with iterate_devices.
    
    The iterate_devices method calls its callback for every underlying
    device in the target.  If any callback returns non-zero, iterate_devices
    exits immediately.  But the callback device_area_is_valid() returns 0 on
    error and 1 on success.  The overall effect without is that an error is
    issued only if every device is invalid.
    
    This patch renames device_area_is_valid to device_area_is_invalid and
    inverts the logic so that one invalid device is sufficient to raise
    an error.
    Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
    Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
    Signed-off-by: default avatarAlasdair G Kergon <agk@redhat.com>
    f6a1ed10
dm-table.c 27.1 KB