• Paul Mackerras's avatar
    perf_counter: Check task on counter read IPI · e1ac3614
    Paul Mackerras authored
    In general, code in perf_counter.c that is called through an
    IPI checks, for per-task counters, that the counter's task is
    still the current task.  This is to handle the race condition
    where the cpu switches from the task we want to another task in
    the interval between sending the IPI and the IPI arriving and
    being handled on the target CPU.
    
    For some reason, __perf_counter_read is missing this check, yet
    there is no reason why the race condition can't occur.  This
    adds a check that the current task is the one we want.  If it
    isn't, we just return.  In that case the counter->count value
    should be up to date, since it will have been updated when the
    counter was scheduled out, which must have happened since the
    IPI was sent.
    
    I don't have an example of an actual failure due to this race,
    but it seems obvious that it could occur and we need to guard
    against it.
    Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
    Acked-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
    LKML-Reference: <19076.63614.277861.368125@drongo.ozlabs.ibm.com>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    e1ac3614
perf_counter.c 113 KB