• Linus Torvalds's avatar
    Allow opportunistic merging of VM_CAN_NONLINEAR areas · 33bfad54
    Linus Torvalds authored
    Commit de33c8db ("Fix OOPS in
    mmap_region() when merging adjacent VM_LOCKED file segments") unified
    the vma merging of anonymous and file maps to just one place, which
    simplified the code and fixed a use-after-free bug that could cause an
    oops.
    
    But by doing the merge opportunistically before even having called
    ->mmap() on the file method, it now compares two different 'vm_flags'
    values: the pre-mmap() value of the new not-yet-formed vma, and previous
    mappings of the same file around it.
    
    And in doing so, it refused to merge the common file case, which adds a
    marker to say "I can be made non-linear".
    
    This fixes it by just adding a set of flags that don't have to match,
    because we know they are ok to merge.  Currently it's only that single
    VM_CAN_NONLINEAR flag, but at least conceptually there could be others
    in the future.
    Reported-and-acked-by: default avatarHugh Dickins <hugh@veritas.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
    Cc: Nick Piggin <npiggin@suse.de>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Greg KH <gregkh@suse.de>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    33bfad54
mmap.c 64.2 KB