Commit ebd8bb76 authored by James Bottomley's avatar James Bottomley Committed by James Bottomley

[SCSI] fix transport class corner case after rework

If your transport class sets the ATTRIBUTE_CONTAINER_NO_CLASSDEVS flag,
then its configure method never gets called.  This patch fixes that so
that the configure method is called with a NULL classdev.

Also remove a spurious inverted comma in the transport_class comments.
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent 975f24bd
...@@ -237,6 +237,11 @@ attribute_container_device_trigger(struct device *dev, ...@@ -237,6 +237,11 @@ attribute_container_device_trigger(struct device *dev,
if (!cont->match(cont, dev)) if (!cont->match(cont, dev))
continue; continue;
if (attribute_container_no_classdevs(cont)) {
fn(cont, dev, NULL);
continue;
}
spin_lock(&cont->containers_lock); spin_lock(&cont->containers_lock);
list_for_each_entry_safe(ic, tmp, &cont->containers, node) { list_for_each_entry_safe(ic, tmp, &cont->containers, node) {
if (dev == ic->classdev.dev) if (dev == ic->classdev.dev)
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
* This file is licensed under GPLv2 * This file is licensed under GPLv2
* *
* The basic idea here is to allow any "device controller" (which * The basic idea here is to allow any "device controller" (which
* would most often be a Host Bus Adapter" to use the services of one * would most often be a Host Bus Adapter to use the services of one
* or more tranport classes for performing transport specific * or more tranport classes for performing transport specific
* services. Transport specific services are things that the generic * services. Transport specific services are things that the generic
* command layer doesn't want to know about (speed settings, line * command layer doesn't want to know about (speed settings, line
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment