Commit acf1da45 authored by Pierre Ossman's avatar Pierre Ossman

mmc: sdhci: Stop asking for mail

We get enough error reports without having to ask for it.
Remove notices about mailing the development list.
Signed-off-by: default avatarPierre Ossman <drzeus@drzeus.cx>
parent 52fbf9c9
...@@ -23,8 +23,6 @@ ...@@ -23,8 +23,6 @@
#define DRIVER_NAME "sdhci" #define DRIVER_NAME "sdhci"
#define BUGMAIL "<sdhci-devel@list.drzeus.cx>"
#define DBG(f, x...) \ #define DBG(f, x...) \
pr_debug(DRIVER_NAME " [%s()]: " f, __func__,## x) pr_debug(DRIVER_NAME " [%s()]: " f, __func__,## x)
...@@ -153,8 +151,7 @@ static void sdhci_reset(struct sdhci_host *host, u8 mask) ...@@ -153,8 +151,7 @@ static void sdhci_reset(struct sdhci_host *host, u8 mask)
/* hw clears the bit when it's done */ /* hw clears the bit when it's done */
while (readb(host->ioaddr + SDHCI_SOFTWARE_RESET) & mask) { while (readb(host->ioaddr + SDHCI_SOFTWARE_RESET) & mask) {
if (timeout == 0) { if (timeout == 0) {
printk(KERN_ERR "%s: Reset 0x%x never completed. " printk(KERN_ERR "%s: Reset 0x%x never completed.\n",
"Please report this to " BUGMAIL ".\n",
mmc_hostname(host->mmc), (int)mask); mmc_hostname(host->mmc), (int)mask);
sdhci_dumpregs(host); sdhci_dumpregs(host);
return; return;
...@@ -473,12 +470,11 @@ static void sdhci_finish_data(struct sdhci_host *host) ...@@ -473,12 +470,11 @@ static void sdhci_finish_data(struct sdhci_host *host)
if ((data->error == MMC_ERR_NONE) && blocks) { if ((data->error == MMC_ERR_NONE) && blocks) {
printk(KERN_ERR "%s: Controller signalled completion even " printk(KERN_ERR "%s: Controller signalled completion even "
"though there were blocks left. Please report this " "though there were blocks left.\n",
"to " BUGMAIL ".\n", mmc_hostname(host->mmc)); mmc_hostname(host->mmc));
data->error = MMC_ERR_FAILED; data->error = MMC_ERR_FAILED;
} else if (host->size != 0) { } else if (host->size != 0) {
printk(KERN_ERR "%s: %d bytes were left untransferred. " printk(KERN_ERR "%s: %d bytes were left untransferred.\n",
"Please report this to " BUGMAIL ".\n",
mmc_hostname(host->mmc), host->size); mmc_hostname(host->mmc), host->size);
data->error = MMC_ERR_FAILED; data->error = MMC_ERR_FAILED;
} }
...@@ -525,8 +521,7 @@ static void sdhci_send_command(struct sdhci_host *host, struct mmc_command *cmd) ...@@ -525,8 +521,7 @@ static void sdhci_send_command(struct sdhci_host *host, struct mmc_command *cmd)
while (readl(host->ioaddr + SDHCI_PRESENT_STATE) & mask) { while (readl(host->ioaddr + SDHCI_PRESENT_STATE) & mask) {
if (timeout == 0) { if (timeout == 0) {
printk(KERN_ERR "%s: Controller never released " printk(KERN_ERR "%s: Controller never released "
"inhibit bit(s). Please report this to " "inhibit bit(s).\n", mmc_hostname(host->mmc));
BUGMAIL ".\n", mmc_hostname(host->mmc));
sdhci_dumpregs(host); sdhci_dumpregs(host);
cmd->error = MMC_ERR_FAILED; cmd->error = MMC_ERR_FAILED;
tasklet_schedule(&host->finish_tasklet); tasklet_schedule(&host->finish_tasklet);
...@@ -547,8 +542,7 @@ static void sdhci_send_command(struct sdhci_host *host, struct mmc_command *cmd) ...@@ -547,8 +542,7 @@ static void sdhci_send_command(struct sdhci_host *host, struct mmc_command *cmd)
sdhci_set_transfer_mode(host, cmd->data); sdhci_set_transfer_mode(host, cmd->data);
if ((cmd->flags & MMC_RSP_136) && (cmd->flags & MMC_RSP_BUSY)) { if ((cmd->flags & MMC_RSP_136) && (cmd->flags & MMC_RSP_BUSY)) {
printk(KERN_ERR "%s: Unsupported response type! " printk(KERN_ERR "%s: Unsupported response type!\n",
"Please report this to " BUGMAIL ".\n",
mmc_hostname(host->mmc)); mmc_hostname(host->mmc));
cmd->error = MMC_ERR_INVALID; cmd->error = MMC_ERR_INVALID;
tasklet_schedule(&host->finish_tasklet); tasklet_schedule(&host->finish_tasklet);
...@@ -646,9 +640,8 @@ static void sdhci_set_clock(struct sdhci_host *host, unsigned int clock) ...@@ -646,9 +640,8 @@ static void sdhci_set_clock(struct sdhci_host *host, unsigned int clock)
while (!((clk = readw(host->ioaddr + SDHCI_CLOCK_CONTROL)) while (!((clk = readw(host->ioaddr + SDHCI_CLOCK_CONTROL))
& SDHCI_CLOCK_INT_STABLE)) { & SDHCI_CLOCK_INT_STABLE)) {
if (timeout == 0) { if (timeout == 0) {
printk(KERN_ERR "%s: Internal clock never stabilised. " printk(KERN_ERR "%s: Internal clock never "
"Please report this to " BUGMAIL ".\n", "stabilised.\n", mmc_hostname(host->mmc));
mmc_hostname(host->mmc));
sdhci_dumpregs(host); sdhci_dumpregs(host);
return; return;
} }
...@@ -898,9 +891,8 @@ static void sdhci_timeout_timer(unsigned long data) ...@@ -898,9 +891,8 @@ static void sdhci_timeout_timer(unsigned long data)
spin_lock_irqsave(&host->lock, flags); spin_lock_irqsave(&host->lock, flags);
if (host->mrq) { if (host->mrq) {
printk(KERN_ERR "%s: Timeout waiting for hardware interrupt. " printk(KERN_ERR "%s: Timeout waiting for hardware "
"Please report this to " BUGMAIL ".\n", "interrupt.\n", mmc_hostname(host->mmc));
mmc_hostname(host->mmc));
sdhci_dumpregs(host); sdhci_dumpregs(host);
if (host->data) { if (host->data) {
...@@ -934,8 +926,6 @@ static void sdhci_cmd_irq(struct sdhci_host *host, u32 intmask) ...@@ -934,8 +926,6 @@ static void sdhci_cmd_irq(struct sdhci_host *host, u32 intmask)
printk(KERN_ERR "%s: Got command interrupt even though no " printk(KERN_ERR "%s: Got command interrupt even though no "
"command operation was in progress.\n", "command operation was in progress.\n",
mmc_hostname(host->mmc)); mmc_hostname(host->mmc));
printk(KERN_ERR "%s: Please report this to " BUGMAIL ".\n",
mmc_hostname(host->mmc));
sdhci_dumpregs(host); sdhci_dumpregs(host);
return; return;
} }
...@@ -971,8 +961,6 @@ static void sdhci_data_irq(struct sdhci_host *host, u32 intmask) ...@@ -971,8 +961,6 @@ static void sdhci_data_irq(struct sdhci_host *host, u32 intmask)
printk(KERN_ERR "%s: Got data interrupt even though no " printk(KERN_ERR "%s: Got data interrupt even though no "
"data operation was in progress.\n", "data operation was in progress.\n",
mmc_hostname(host->mmc)); mmc_hostname(host->mmc));
printk(KERN_ERR "%s: Please report this to " BUGMAIL ".\n",
mmc_hostname(host->mmc));
sdhci_dumpregs(host); sdhci_dumpregs(host);
return; return;
...@@ -1044,8 +1032,7 @@ static irqreturn_t sdhci_irq(int irq, void *dev_id) ...@@ -1044,8 +1032,7 @@ static irqreturn_t sdhci_irq(int irq, void *dev_id)
intmask &= SDHCI_INT_BUS_POWER; intmask &= SDHCI_INT_BUS_POWER;
if (intmask) { if (intmask) {
printk(KERN_ERR "%s: Unexpected interrupt 0x%08x. Please " printk(KERN_ERR "%s: Unexpected interrupt 0x%08x.\n",
"report this to " BUGMAIL ".\n",
mmc_hostname(host->mmc), intmask); mmc_hostname(host->mmc), intmask);
sdhci_dumpregs(host); sdhci_dumpregs(host);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment