Commit 9092f46b authored by John W. Linville's avatar John W. Linville Committed by Jeff Garzik

[PATCH] tulip: add return to ULI526X clause in tulip_mdio_write

The 'if' clause for ULI526X in tulip_mdio_write allows for
spin_unlock_irqrestore to be called twice for tp->mii_lock.  I believe
this is caused by the unintentional omission of a return at the end
of that clause.  This patch adds that return.
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 187a1a94
...@@ -174,6 +174,7 @@ void tulip_mdio_write(struct net_device *dev, int phy_id, int location, int val) ...@@ -174,6 +174,7 @@ void tulip_mdio_write(struct net_device *dev, int phy_id, int location, int val)
break; break;
} }
spin_unlock_irqrestore(&tp->mii_lock, flags); spin_unlock_irqrestore(&tp->mii_lock, flags);
return;
} }
/* Establish sync by sending 32 logic ones. */ /* Establish sync by sending 32 logic ones. */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment