Commit 6f9d4722 authored by Eric Sesterhenn's avatar Eric Sesterhenn Committed by Jeff Garzik

[PATCH] acenic: fix checking of read_eeprom_byte() return values

tmp in ace_init is u32 thus rendering read_eeprom_byte() return values
checks useless.
Signed-off-by: default avatarEric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: default avatarJeff Garzik <jgarzik@pobox.com>
parent 6a986ce4
...@@ -1002,6 +1002,8 @@ static int __devinit ace_init(struct net_device *dev) ...@@ -1002,6 +1002,8 @@ static int __devinit ace_init(struct net_device *dev)
mac1 = 0; mac1 = 0;
for(i = 0; i < 4; i++) { for(i = 0; i < 4; i++) {
int tmp;
mac1 = mac1 << 8; mac1 = mac1 << 8;
tmp = read_eeprom_byte(dev, 0x8c+i); tmp = read_eeprom_byte(dev, 0x8c+i);
if (tmp < 0) { if (tmp < 0) {
...@@ -1012,6 +1014,8 @@ static int __devinit ace_init(struct net_device *dev) ...@@ -1012,6 +1014,8 @@ static int __devinit ace_init(struct net_device *dev)
} }
mac2 = 0; mac2 = 0;
for(i = 4; i < 8; i++) { for(i = 4; i < 8; i++) {
int tmp;
mac2 = mac2 << 8; mac2 = mac2 << 8;
tmp = read_eeprom_byte(dev, 0x8c+i); tmp = read_eeprom_byte(dev, 0x8c+i);
if (tmp < 0) { if (tmp < 0) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment