Commit 6c912a3d authored by Arnaud Patard (Rtp's avatar Arnaud Patard (Rtp Committed by Linus Torvalds

[PATCH] spi_s3c24xx.c: warning fix

The set_cs field of struct s3c24xx_spi is declared as returning a int but
the value returned but set_cs is never fixed.  Moreover, the default
function for set_cs and the set_cs defintion in the platform data are
returning void.

I'm proposing to change the prototype to void (*set_cs)(...). By doing
this, I'm also fixing 2 build warnings:

  drivers/spi/spi_s3c24xx.c: In function 's3c24xx_spi_probe':
  drivers/spi/spi_s3c24xx.c:330: warning: assignment from incompatible pointer type
  drivers/spi/spi_s3c24xx.c:335: warning: assignment from incompatible pointer type
Signed-off-by: default avatarArnaud Patard <arnaud.patard@rtp-net.org>
Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent d1cabd63
...@@ -41,7 +41,7 @@ struct s3c24xx_spi { ...@@ -41,7 +41,7 @@ struct s3c24xx_spi {
int len; int len;
int count; int count;
int (*set_cs)(struct s3c2410_spi_info *spi, void (*set_cs)(struct s3c2410_spi_info *spi,
int cs, int pol); int cs, int pol);
/* data buffers */ /* data buffers */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment