Commit 484e389c authored by Miklos Szeredi's avatar Miklos Szeredi Committed by Linus Torvalds

[PATCH] set mnt_namespace in the correct place

This patch sets ->mnt_namespace where it's actually added to the
namespace.

Previously mnt_namespace was set in do_kern_mount() even if the filesystem
was never added to any process's namespace (most kernel-internal
filesystems).

This discrepancy doesn't actually cause any problems, but it's cleaner if
mnt_namespace is NULL for these non exported filesystems.
Signed-off-by: default avatarMiklos Szeredi <miklos@szeredi.hu>
Acked-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent ac081153
...@@ -808,6 +808,7 @@ int do_add_mount(struct vfsmount *newmnt, struct nameidata *nd, ...@@ -808,6 +808,7 @@ int do_add_mount(struct vfsmount *newmnt, struct nameidata *nd,
goto unlock; goto unlock;
newmnt->mnt_flags = mnt_flags; newmnt->mnt_flags = mnt_flags;
newmnt->mnt_namespace = current->namespace;
err = graft_tree(newmnt, nd); err = graft_tree(newmnt, nd);
if (err == 0 && fslist) { if (err == 0 && fslist) {
......
...@@ -840,7 +840,6 @@ do_kern_mount(const char *fstype, int flags, const char *name, void *data) ...@@ -840,7 +840,6 @@ do_kern_mount(const char *fstype, int flags, const char *name, void *data)
mnt->mnt_root = dget(sb->s_root); mnt->mnt_root = dget(sb->s_root);
mnt->mnt_mountpoint = sb->s_root; mnt->mnt_mountpoint = sb->s_root;
mnt->mnt_parent = mnt; mnt->mnt_parent = mnt;
mnt->mnt_namespace = current->namespace;
up_write(&sb->s_umount); up_write(&sb->s_umount);
free_secdata(secdata); free_secdata(secdata);
put_filesystem(type); put_filesystem(type);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment