Commit 19f03ffe authored by Andi Kleen's avatar Andi Kleen Committed by Andi Kleen

[PATCH] i386: Clean up code style in mpparse.c ACPI code

Remove some unlinuxy ways to write function parameter definitions.
Remove some stray "return;"s

No functional change.

Cc: len.brown@intel.com
Signed-off-by: default avatarAndi Kleen <ak@suse.de>
parent efec3b9a
...@@ -810,8 +810,7 @@ int es7000_plat; ...@@ -810,8 +810,7 @@ int es7000_plat;
#ifdef CONFIG_ACPI #ifdef CONFIG_ACPI
void __init mp_register_lapic_address ( void __init mp_register_lapic_address(u64 address)
u64 address)
{ {
mp_lapic_addr = (unsigned long) address; mp_lapic_addr = (unsigned long) address;
...@@ -823,10 +822,7 @@ void __init mp_register_lapic_address ( ...@@ -823,10 +822,7 @@ void __init mp_register_lapic_address (
Dprintk("Boot CPU = %d\n", boot_cpu_physical_apicid); Dprintk("Boot CPU = %d\n", boot_cpu_physical_apicid);
} }
void __devinit mp_register_lapic (u8 id, u8 enabled)
void __devinit mp_register_lapic (
u8 id,
u8 enabled)
{ {
struct mpc_config_processor processor; struct mpc_config_processor processor;
int boot_cpu = 0; int boot_cpu = 0;
...@@ -866,9 +862,7 @@ static struct mp_ioapic_routing { ...@@ -866,9 +862,7 @@ static struct mp_ioapic_routing {
u32 pin_programmed[4]; u32 pin_programmed[4];
} mp_ioapic_routing[MAX_IO_APICS]; } mp_ioapic_routing[MAX_IO_APICS];
static int mp_find_ioapic (int gsi)
static int mp_find_ioapic (
int gsi)
{ {
int i = 0; int i = 0;
...@@ -884,11 +878,7 @@ static int mp_find_ioapic ( ...@@ -884,11 +878,7 @@ static int mp_find_ioapic (
return -1; return -1;
} }
void __init mp_register_ioapic(u8 id, u32 address, u32 gsi_base)
void __init mp_register_ioapic (
u8 id,
u32 address,
u32 gsi_base)
{ {
int idx = 0; int idx = 0;
int tmpid; int tmpid;
...@@ -937,16 +927,10 @@ void __init mp_register_ioapic ( ...@@ -937,16 +927,10 @@ void __init mp_register_ioapic (
mp_ioapics[idx].mpc_apicver, mp_ioapics[idx].mpc_apicaddr, mp_ioapics[idx].mpc_apicver, mp_ioapics[idx].mpc_apicaddr,
mp_ioapic_routing[idx].gsi_base, mp_ioapic_routing[idx].gsi_base,
mp_ioapic_routing[idx].gsi_end); mp_ioapic_routing[idx].gsi_end);
return;
} }
void __init
void __init mp_override_legacy_irq ( mp_override_legacy_irq(u8 bus_irq, u8 polarity, u8 trigger, u32 gsi)
u8 bus_irq,
u8 polarity,
u8 trigger,
u32 gsi)
{ {
struct mpc_config_intsrc intsrc; struct mpc_config_intsrc intsrc;
int ioapic = -1; int ioapic = -1;
...@@ -984,8 +968,6 @@ void __init mp_override_legacy_irq ( ...@@ -984,8 +968,6 @@ void __init mp_override_legacy_irq (
mp_irqs[mp_irq_entries] = intsrc; mp_irqs[mp_irq_entries] = intsrc;
if (++mp_irq_entries == MAX_IRQ_SOURCES) if (++mp_irq_entries == MAX_IRQ_SOURCES)
panic("Max # of irq sources exceeded!\n"); panic("Max # of irq sources exceeded!\n");
return;
} }
void __init mp_config_acpi_legacy_irqs (void) void __init mp_config_acpi_legacy_irqs (void)
...@@ -1061,7 +1043,7 @@ void __init mp_config_acpi_legacy_irqs (void) ...@@ -1061,7 +1043,7 @@ void __init mp_config_acpi_legacy_irqs (void)
#define MAX_GSI_NUM 4096 #define MAX_GSI_NUM 4096
int mp_register_gsi (u32 gsi, int triggering, int polarity) int mp_register_gsi(u32 gsi, int triggering, int polarity)
{ {
int ioapic = -1; int ioapic = -1;
int ioapic_pin = 0; int ioapic_pin = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment