Commit 052dfb45 authored by Douglas Thompson's avatar Douglas Thompson Committed by Linus Torvalds

drivers/edac: cleanup spaces-gotos after Lindent messup

This patch fixes some remnant spaces inserted by the use of Lindent.
Seems Lindent adds some spaces when it shoulded. These have been fixed.
In addition, goto targets have issues, these have been fixed
in this patch.
Signed-off-by: default avatarDouglas Thompson <dougthompson@xmission.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 6bc78404
...@@ -283,7 +283,7 @@ static int amd76x_probe1(struct pci_dev *pdev, int dev_idx) ...@@ -283,7 +283,7 @@ static int amd76x_probe1(struct pci_dev *pdev, int dev_idx)
debugf3("%s(): success\n", __func__); debugf3("%s(): success\n", __func__);
return 0; return 0;
fail: fail:
edac_mc_free(mci); edac_mc_free(mci);
return -ENODEV; return -ENODEV;
} }
......
...@@ -865,10 +865,10 @@ static void e752x_init_mem_map_table(struct pci_dev *pdev, ...@@ -865,10 +865,10 @@ static void e752x_init_mem_map_table(struct pci_dev *pdev,
*/ */
pci_read_config_byte(pdev, E752X_DRB + index + 1, pci_read_config_byte(pdev, E752X_DRB + index + 1,
&value); &value);
pvt->map[index + 1] = (value == last) ? 0xff : /* the dimm is single sided,
so flag as empty */ /* the dimm is single sided, so flag as empty */
row; /* this is a double sided dimm /* this is a double sided dimm to save the next row #*/
to save the next row # */ pvt->map[index + 1] = (value == last) ? 0xff : row;
row++; row++;
last = value; last = value;
} }
...@@ -910,7 +910,7 @@ static int e752x_get_devs(struct pci_dev *pdev, int dev_idx, ...@@ -910,7 +910,7 @@ static int e752x_get_devs(struct pci_dev *pdev, int dev_idx,
return 0; return 0;
fail: fail:
pci_dev_put(pvt->bridge_ck); pci_dev_put(pvt->bridge_ck);
return 1; return 1;
} }
...@@ -1021,8 +1021,8 @@ static int e752x_probe1(struct pci_dev *pdev, int dev_idx) ...@@ -1021,8 +1021,8 @@ static int e752x_probe1(struct pci_dev *pdev, int dev_idx)
pci_read_config_word(pdev, E752X_REMAPLIMIT, &pci_data); pci_read_config_word(pdev, E752X_REMAPLIMIT, &pci_data);
pvt->remaplimit = ((u32) pci_data) << 14; pvt->remaplimit = ((u32) pci_data) << 14;
e752x_printk(KERN_INFO, e752x_printk(KERN_INFO,
"tolm = %x, remapbase = %x, remaplimit = %x\n", pvt->tolm, "tolm = %x, remapbase = %x, remaplimit = %x\n",
pvt->remapbase, pvt->remaplimit); pvt->tolm, pvt->remapbase, pvt->remaplimit);
/* Here we assume that we will never see multiple instances of this /* Here we assume that we will never see multiple instances of this
* type of memory controller. The ID is therefore hardcoded to 0. * type of memory controller. The ID is therefore hardcoded to 0.
...@@ -1041,14 +1041,15 @@ static int e752x_probe1(struct pci_dev *pdev, int dev_idx) ...@@ -1041,14 +1041,15 @@ static int e752x_probe1(struct pci_dev *pdev, int dev_idx)
printk(KERN_WARNING printk(KERN_WARNING
"%s(): Unable to create PCI control\n", __func__); "%s(): Unable to create PCI control\n", __func__);
printk(KERN_WARNING printk(KERN_WARNING
"%s(): PCI error report via EDAC not setup\n", __func__); "%s(): PCI error report via EDAC not setup\n",
__func__);
} }
/* get this far and it's successful */ /* get this far and it's successful */
debugf3("%s(): success\n", __func__); debugf3("%s(): success\n", __func__);
return 0; return 0;
fail: fail:
pci_dev_put(pvt->dev_d0f0); pci_dev_put(pvt->dev_d0f0);
pci_dev_put(pvt->dev_d0f1); pci_dev_put(pvt->dev_d0f1);
pci_dev_put(pvt->bridge_ck); pci_dev_put(pvt->bridge_ck);
......
...@@ -498,10 +498,10 @@ static int e7xxx_probe1(struct pci_dev *pdev, int dev_idx) ...@@ -498,10 +498,10 @@ static int e7xxx_probe1(struct pci_dev *pdev, int dev_idx)
debugf3("%s(): success\n", __func__); debugf3("%s(): success\n", __func__);
return 0; return 0;
fail1: fail1:
pci_dev_put(pvt->bridge_ck); pci_dev_put(pvt->bridge_ck);
fail0: fail0:
edac_mc_free(mci); edac_mc_free(mci);
return -ENODEV; return -ENODEV;
......
...@@ -257,14 +257,14 @@ static int add_edac_dev_to_global_list(struct edac_device_ctl_info *edac_dev) ...@@ -257,14 +257,14 @@ static int add_edac_dev_to_global_list(struct edac_device_ctl_info *edac_dev)
list_add_tail_rcu(&edac_dev->link, insert_before); list_add_tail_rcu(&edac_dev->link, insert_before);
return 0; return 0;
fail0: fail0:
edac_printk(KERN_WARNING, EDAC_MC, edac_printk(KERN_WARNING, EDAC_MC,
"%s (%s) %s %s already assigned %d\n", "%s (%s) %s %s already assigned %d\n",
rover->dev->bus_id, dev_name(rover), rover->dev->bus_id, dev_name(rover),
rover->mod_name, rover->ctl_name, rover->dev_idx); rover->mod_name, rover->ctl_name, rover->dev_idx);
return 1; return 1;
fail1: fail1:
edac_printk(KERN_WARNING, EDAC_MC, edac_printk(KERN_WARNING, EDAC_MC,
"bug in low-level driver: attempt to assign\n" "bug in low-level driver: attempt to assign\n"
" duplicate dev_idx %d in %s()\n", rover->dev_idx, " duplicate dev_idx %d in %s()\n", rover->dev_idx,
...@@ -454,21 +454,21 @@ int edac_device_add_device(struct edac_device_ctl_info *edac_dev, int edac_idx) ...@@ -454,21 +454,21 @@ int edac_device_add_device(struct edac_device_ctl_info *edac_dev, int edac_idx)
/* Report action taken */ /* Report action taken */
edac_device_printk(edac_dev, KERN_INFO, edac_device_printk(edac_dev, KERN_INFO,
"Giving out device to module '%s' controller '%s': DEV '%s' (%s)\n", "Giving out device to module '%s' controller "
"'%s': DEV '%s' (%s)\n",
edac_dev->mod_name, edac_dev->mod_name,
edac_dev->ctl_name, edac_dev->ctl_name,
dev_name(edac_dev), dev_name(edac_dev),
edac_op_state_toString(edac_dev->op_state) edac_op_state_toString(edac_dev->op_state));
);
unlock_device_list(); unlock_device_list();
return 0; return 0;
fail1: fail1:
/* Some error, so remove the entry from the lsit */ /* Some error, so remove the entry from the lsit */
del_edac_device_from_global_list(edac_dev); del_edac_device_from_global_list(edac_dev);
fail0: fail0:
unlock_device_list(); unlock_device_list();
return 1; return 1;
} }
...@@ -563,8 +563,9 @@ void edac_device_handle_ce(struct edac_device_ctl_info *edac_dev, ...@@ -563,8 +563,9 @@ void edac_device_handle_ce(struct edac_device_ctl_info *edac_dev,
if ((block_nr >= instance->nr_blocks) || (block_nr < 0)) { if ((block_nr >= instance->nr_blocks) || (block_nr < 0)) {
edac_device_printk(edac_dev, KERN_ERR, edac_device_printk(edac_dev, KERN_ERR,
"INTERNAL ERROR: instance %d 'block' out of range " "INTERNAL ERROR: instance %d 'block' "
"(%d >= %d)\n", inst_nr, block_nr, "out of range (%d >= %d)\n",
inst_nr, block_nr,
instance->nr_blocks); instance->nr_blocks);
return; return;
} }
...@@ -609,8 +610,9 @@ void edac_device_handle_ue(struct edac_device_ctl_info *edac_dev, ...@@ -609,8 +610,9 @@ void edac_device_handle_ue(struct edac_device_ctl_info *edac_dev,
if ((block_nr >= instance->nr_blocks) || (block_nr < 0)) { if ((block_nr >= instance->nr_blocks) || (block_nr < 0)) {
edac_device_printk(edac_dev, KERN_ERR, edac_device_printk(edac_dev, KERN_ERR,
"INTERNAL ERROR: instance %d 'block' out of range " "INTERNAL ERROR: instance %d 'block' "
"(%d >= %d)\n", inst_nr, block_nr, "out of range (%d >= %d)\n",
inst_nr, block_nr,
instance->nr_blocks); instance->nr_blocks);
return; return;
} }
......
...@@ -334,13 +334,13 @@ static int add_mc_to_global_list(struct mem_ctl_info *mci) ...@@ -334,13 +334,13 @@ static int add_mc_to_global_list(struct mem_ctl_info *mci)
atomic_inc(&edac_handlers); atomic_inc(&edac_handlers);
return 0; return 0;
fail0: fail0:
edac_printk(KERN_WARNING, EDAC_MC, edac_printk(KERN_WARNING, EDAC_MC,
"%s (%s) %s %s already assigned %d\n", p->dev->bus_id, "%s (%s) %s %s already assigned %d\n", p->dev->bus_id,
dev_name(mci), p->mod_name, p->ctl_name, p->mc_idx); dev_name(mci), p->mod_name, p->ctl_name, p->mc_idx);
return 1; return 1;
fail1: fail1:
edac_printk(KERN_WARNING, EDAC_MC, edac_printk(KERN_WARNING, EDAC_MC,
"bug in low-level driver: attempt to assign\n" "bug in low-level driver: attempt to assign\n"
" duplicate mc_idx %d in %s()\n", p->mc_idx, __func__); " duplicate mc_idx %d in %s()\n", p->mc_idx, __func__);
...@@ -458,10 +458,10 @@ int edac_mc_add_mc(struct mem_ctl_info *mci, int mc_idx) ...@@ -458,10 +458,10 @@ int edac_mc_add_mc(struct mem_ctl_info *mci, int mc_idx)
mutex_unlock(&mem_ctls_mutex); mutex_unlock(&mem_ctls_mutex);
return 0; return 0;
fail1: fail1:
del_mc_from_global_list(mci); del_mc_from_global_list(mci);
fail0: fail0:
mutex_unlock(&mem_ctls_mutex); mutex_unlock(&mem_ctls_mutex);
return 1; return 1;
} }
......
...@@ -531,7 +531,7 @@ static int edac_create_csrow_object(struct kobject *edac_mci_kobj, ...@@ -531,7 +531,7 @@ static int edac_create_csrow_object(struct kobject *edac_mci_kobj,
} }
} }
error_exit: error_exit:
return err; return err;
} }
...@@ -841,7 +841,7 @@ int edac_create_sysfs_mci_device(struct mem_ctl_info *mci) ...@@ -841,7 +841,7 @@ int edac_create_sysfs_mci_device(struct mem_ctl_info *mci)
return 0; return 0;
/* CSROW error: backout what has already been registered, */ /* CSROW error: backout what has already been registered, */
fail1: fail1:
for (i--; i >= 0; i--) { for (i--; i >= 0; i--) {
if (csrow->nr_pages > 0) { if (csrow->nr_pages > 0) {
init_completion(&csrow->kobj_complete); init_completion(&csrow->kobj_complete);
...@@ -850,7 +850,7 @@ int edac_create_sysfs_mci_device(struct mem_ctl_info *mci) ...@@ -850,7 +850,7 @@ int edac_create_sysfs_mci_device(struct mem_ctl_info *mci)
} }
} }
fail0: fail0:
init_completion(&mci->kobj_complete); init_completion(&mci->kobj_complete);
kobject_unregister(edac_mci_kobj); kobject_unregister(edac_mci_kobj);
wait_for_completion(&mci->kobj_complete); wait_for_completion(&mci->kobj_complete);
......
...@@ -181,11 +181,11 @@ static int __init edac_init(void) ...@@ -181,11 +181,11 @@ static int __init edac_init(void)
return 0; return 0;
/* Error teardown stack */ /* Error teardown stack */
error_mem: error_mem:
edac_sysfs_memctrl_teardown(); edac_sysfs_memctrl_teardown();
error_sysfs: error_sysfs:
edac_unregister_sysfs_edac_name(); edac_unregister_sysfs_edac_name();
error: error:
return err; return err;
} }
......
...@@ -140,14 +140,14 @@ static int add_edac_pci_to_global_list(struct edac_pci_ctl_info *pci) ...@@ -140,14 +140,14 @@ static int add_edac_pci_to_global_list(struct edac_pci_ctl_info *pci)
list_add_tail_rcu(&pci->link, insert_before); list_add_tail_rcu(&pci->link, insert_before);
return 0; return 0;
fail0: fail0:
edac_printk(KERN_WARNING, EDAC_PCI, edac_printk(KERN_WARNING, EDAC_PCI,
"%s (%s) %s %s already assigned %d\n", "%s (%s) %s %s already assigned %d\n",
rover->dev->bus_id, dev_name(rover), rover->dev->bus_id, dev_name(rover),
rover->mod_name, rover->ctl_name, rover->pci_idx); rover->mod_name, rover->ctl_name, rover->pci_idx);
return 1; return 1;
fail1: fail1:
edac_printk(KERN_WARNING, EDAC_PCI, edac_printk(KERN_WARNING, EDAC_PCI,
"but in low-level driver: attempt to assign\n" "but in low-level driver: attempt to assign\n"
"\tduplicate pci_idx %d in %s()\n", rover->pci_idx, "\tduplicate pci_idx %d in %s()\n", rover->pci_idx,
...@@ -326,9 +326,9 @@ int edac_pci_add_device(struct edac_pci_ctl_info *pci, int edac_idx) ...@@ -326,9 +326,9 @@ int edac_pci_add_device(struct edac_pci_ctl_info *pci, int edac_idx)
edac_unlock_pci_list(); edac_unlock_pci_list();
return 0; return 0;
fail1: fail1:
del_edac_pci_from_global_list(pci); del_edac_pci_from_global_list(pci);
fail0: fail0:
edac_unlock_pci_list(); edac_unlock_pci_list();
return 1; return 1;
} }
......
...@@ -250,7 +250,8 @@ static int i3000_is_interleaved(const unsigned char *c0dra, ...@@ -250,7 +250,8 @@ static int i3000_is_interleaved(const unsigned char *c0dra,
*/ */
for (i = 0; i < I3000_RANKS_PER_CHANNEL / 2; i++) for (i = 0; i < I3000_RANKS_PER_CHANNEL / 2; i++)
if (ODD_RANK_ATTRIB(c0dra[i]) != ODD_RANK_ATTRIB(c1dra[i]) || if (ODD_RANK_ATTRIB(c0dra[i]) != ODD_RANK_ATTRIB(c1dra[i]) ||
EVEN_RANK_ATTRIB(c0dra[i]) != EVEN_RANK_ATTRIB(c1dra[i])) EVEN_RANK_ATTRIB(c0dra[i]) !=
EVEN_RANK_ATTRIB(c1dra[i]))
return 0; return 0;
/* If the rank boundaries for the two channels are different /* If the rank boundaries for the two channels are different
...@@ -476,10 +477,10 @@ static int __init i3000_init(void) ...@@ -476,10 +477,10 @@ static int __init i3000_init(void)
return 0; return 0;
fail1: fail1:
pci_unregister_driver(&i3000_driver); pci_unregister_driver(&i3000_driver);
fail0: fail0:
if (mci_pdev) if (mci_pdev)
pci_dev_put(mci_pdev); pci_dev_put(mci_pdev);
......
...@@ -1392,11 +1392,11 @@ static int i5000_probe1(struct pci_dev *pdev, int dev_idx) ...@@ -1392,11 +1392,11 @@ static int i5000_probe1(struct pci_dev *pdev, int dev_idx)
return 0; return 0;
/* Error exit unwinding stack */ /* Error exit unwinding stack */
fail1: fail1:
i5000_put_devices(mci); i5000_put_devices(mci);
fail0: fail0:
edac_mc_free(mci); edac_mc_free(mci);
return -ENODEV; return -ENODEV;
} }
......
...@@ -151,8 +151,9 @@ static int i82443bxgx_edacmc_process_error_info(struct mem_ctl_info *mci, ...@@ -151,8 +151,9 @@ static int i82443bxgx_edacmc_process_error_info(struct mem_ctl_info *mci,
error_found = 1; error_found = 1;
if (handle_errors) if (handle_errors)
edac_mc_handle_ce(mci, page, pageoffset, edac_mc_handle_ce(mci, page, pageoffset,
/* 440BX/GX don't make syndrome information available */ /* 440BX/GX don't make syndrome information
0, edac_mc_find_csrow_by_page(mci, page), 0, /* channel */ * available */
0, edac_mc_find_csrow_by_page(mci, page), 0,
mci->ctl_name); mci->ctl_name);
} }
...@@ -233,7 +234,8 @@ static int i82443bxgx_edacmc_probe1(struct pci_dev *pdev, int dev_idx) ...@@ -233,7 +234,8 @@ static int i82443bxgx_edacmc_probe1(struct pci_dev *pdev, int dev_idx)
debugf0("MC: " __FILE__ ": %s()\n", __func__); debugf0("MC: " __FILE__ ": %s()\n", __func__);
/* Something is really hosed if PCI config space reads from /* Something is really hosed if PCI config space reads from
the MC aren't working. */ * the MC aren't working.
*/
if (pci_read_config_dword(pdev, I82443BXGX_NBXCFG, &nbxcfg)) if (pci_read_config_dword(pdev, I82443BXGX_NBXCFG, &nbxcfg))
return -EIO; return -EIO;
...@@ -258,8 +260,8 @@ static int i82443bxgx_edacmc_probe1(struct pci_dev *pdev, int dev_idx) ...@@ -258,8 +260,8 @@ static int i82443bxgx_edacmc_probe1(struct pci_dev *pdev, int dev_idx)
mtype = MEM_RDR; mtype = MEM_RDR;
break; break;
default: default:
debugf0 debugf0("Unknown/reserved DRAM type value "
("Unknown/reserved DRAM type value in DRAMC register!\n"); "in DRAMC register!\n");
mtype = -MEM_UNKNOWN; mtype = -MEM_UNKNOWN;
} }
...@@ -288,9 +290,8 @@ static int i82443bxgx_edacmc_probe1(struct pci_dev *pdev, int dev_idx) ...@@ -288,9 +290,8 @@ static int i82443bxgx_edacmc_probe1(struct pci_dev *pdev, int dev_idx)
edac_mode = EDAC_SECDED; edac_mode = EDAC_SECDED;
break; break;
default: default:
debugf0 debugf0("%s(): Unknown/reserved ECC state "
("%s(): Unknown/reserved ECC state in NBXCFG register!\n", "in NBXCFG register!\n", __func__);
__func__);
edac_mode = EDAC_UNKNOWN; edac_mode = EDAC_UNKNOWN;
break; break;
} }
...@@ -332,7 +333,7 @@ static int i82443bxgx_edacmc_probe1(struct pci_dev *pdev, int dev_idx) ...@@ -332,7 +333,7 @@ static int i82443bxgx_edacmc_probe1(struct pci_dev *pdev, int dev_idx)
debugf3("MC: " __FILE__ ": %s(): success\n", __func__); debugf3("MC: " __FILE__ ": %s(): success\n", __func__);
return 0; return 0;
fail: fail:
edac_mc_free(mci); edac_mc_free(mci);
return -ENODEV; return -ENODEV;
} }
......
...@@ -230,7 +230,7 @@ static int i82860_probe1(struct pci_dev *pdev, int dev_idx) ...@@ -230,7 +230,7 @@ static int i82860_probe1(struct pci_dev *pdev, int dev_idx)
return 0; return 0;
fail: fail:
edac_mc_free(mci); edac_mc_free(mci);
return -ENODEV; return -ENODEV;
} }
...@@ -318,10 +318,10 @@ static int __init i82860_init(void) ...@@ -318,10 +318,10 @@ static int __init i82860_init(void)
return 0; return 0;
fail1: fail1:
pci_unregister_driver(&i82860_driver); pci_unregister_driver(&i82860_driver);
fail0: fail0:
if (mci_pdev != NULL) if (mci_pdev != NULL)
pci_dev_put(mci_pdev); pci_dev_put(mci_pdev);
......
...@@ -265,7 +265,7 @@ static void i82875p_check(struct mem_ctl_info *mci) ...@@ -265,7 +265,7 @@ static void i82875p_check(struct mem_ctl_info *mci)
/* Return 0 on success or 1 on failure. */ /* Return 0 on success or 1 on failure. */
static int i82875p_setup_overfl_dev(struct pci_dev *pdev, static int i82875p_setup_overfl_dev(struct pci_dev *pdev,
struct pci_dev **ovrfl_pdev, struct pci_dev **ovrfl_pdev,
void __iomem ** ovrfl_window) void __iomem **ovrfl_window)
{ {
struct pci_dev *dev; struct pci_dev *dev;
void __iomem *window; void __iomem *window;
...@@ -316,11 +316,11 @@ static int i82875p_setup_overfl_dev(struct pci_dev *pdev, ...@@ -316,11 +316,11 @@ static int i82875p_setup_overfl_dev(struct pci_dev *pdev,
*ovrfl_window = window; *ovrfl_window = window;
return 0; return 0;
fail1: fail1:
pci_release_regions(dev); pci_release_regions(dev);
#ifdef CORRECT_BIOS #ifdef CORRECT_BIOS
fail0: fail0:
pci_disable_device(dev); pci_disable_device(dev);
#endif #endif
/* NOTE: the ovrfl proc entry and pci_dev are intentionally left */ /* NOTE: the ovrfl proc entry and pci_dev are intentionally left */
...@@ -441,10 +441,10 @@ static int i82875p_probe1(struct pci_dev *pdev, int dev_idx) ...@@ -441,10 +441,10 @@ static int i82875p_probe1(struct pci_dev *pdev, int dev_idx)
debugf3("%s(): success\n", __func__); debugf3("%s(): success\n", __func__);
return 0; return 0;
fail1: fail1:
edac_mc_free(mci); edac_mc_free(mci);
fail0: fail0:
iounmap(ovrfl_window); iounmap(ovrfl_window);
pci_release_regions(ovrfl_pdev); pci_release_regions(ovrfl_pdev);
...@@ -551,10 +551,10 @@ static int __init i82875p_init(void) ...@@ -551,10 +551,10 @@ static int __init i82875p_init(void)
return 0; return 0;
fail1: fail1:
pci_unregister_driver(&i82875p_driver); pci_unregister_driver(&i82875p_driver);
fail0: fail0:
if (mci_pdev != NULL) if (mci_pdev != NULL)
pci_dev_put(mci_pdev); pci_dev_put(mci_pdev);
......
...@@ -180,8 +180,9 @@ static int r82600_process_error_info(struct mem_ctl_info *mci, ...@@ -180,8 +180,9 @@ static int r82600_process_error_info(struct mem_ctl_info *mci,
if (handle_errors) if (handle_errors)
edac_mc_handle_ce(mci, page, 0, /* not avail */ edac_mc_handle_ce(mci, page, 0, /* not avail */
syndrome, edac_mc_find_csrow_by_page(mci, page), 0, /* channel */ syndrome,
mci->ctl_name); edac_mc_find_csrow_by_page(mci, page),
0, mci->ctl_name);
} }
if (info->eapr & BIT(1)) { /* UE? */ if (info->eapr & BIT(1)) { /* UE? */
...@@ -342,7 +343,7 @@ static int r82600_probe1(struct pci_dev *pdev, int dev_idx) ...@@ -342,7 +343,7 @@ static int r82600_probe1(struct pci_dev *pdev, int dev_idx)
debugf3("%s(): success\n", __func__); debugf3("%s(): success\n", __func__);
return 0; return 0;
fail: fail:
edac_mc_free(mci); edac_mc_free(mci);
return -ENODEV; return -ENODEV;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment