• Al Viro's avatar
    [PATCH] namei fixes (9/19) · 463ffb2e
    Al Viro authored
    New helper: __follow_mount(struct path *path).  Same as follow_mount(), except
    that we do *not* do mntput() after the first lookup_mnt().
    
    IOW, original path->mnt stays pinned down.  We also take care to do dput()
    before mntput() in the loop body (follow_mount() also needs that reordering,
    but that will be done later in the series).
    
    The following are equivalent, assuming that path.mnt == x:
    (1)
    	follow_mount(&path.mnt, &path.dentry)
    (2)
    	__follow_mount(&path);
    	if (path->mnt != x)
    		mntput(x);
    (3)
    	if (__follow_mount(&path))
    		mntput(x);
    
    Callers of follow_mount() in __link_path_walk() converted to (2).
    
    Equivalent transformation + fix for too-late-mntput() race in __follow_mount()
    loop.
    Signed-off-by: default avatarAl Viro <viro@parcelfarce.linux.theplanet.co.uk>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    463ffb2e
namei.c 59.9 KB