• Corey Minyard's avatar
    [PATCH] ipmi: bt restart reset fixes · 21dcd300
    Corey Minyard authored
    The current BT retry/reset mechanism fails to succeed on a PowerEdge 1650,
    when the controller is wedged with B2H_ATN asserted at XACTION_START.  If this
    occurs, no further commands will ever succeed unless the state of the
    controller is first cleared out.
    
    Furthermore, the soft reset would only occur if the first command after insmod
    was the one that timed out, not if a later command timed out.
    
    This patch changes the retry/reset mechanism to be as follows:
    
    Before retrying a command, clear the state of the BT controller such that the
    flags represent ready for a new transaction.  This increases the chance of
    success of the restarted transaction.
    
    After 2 retries, issue a soft reset and retry one more time before giving up
    and reporting back a failure.
    Signed-off-by: default avatarMatt Domsch <Matt_Domsch@dell.com>
    Acked-by: default avatarRocky Craig <rocky.craig@hp.com>
    Signed-off-by: default avatarCorey Minyard <minyard@acm.org>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    21dcd300
ipmi_bt_sm.c 15.6 KB