• David S. Miller's avatar
    [PATCH] Make sparc64 use setup-res.c · 085ae41f
    David S. Miller authored
    There were three changes necessary in order to allow
    sparc64 to use setup-res.c:
    
    1) Sparc64 roots the PCI I/O and MEM address space using
       parent resources contained in the PCI controller structure.
       I'm actually surprised no other platforms do this, especially
       ones like Alpha and PPC{,64}.  These resources get linked into the
       iomem/ioport tree when PCI controllers are probed.
    
       So the hierarchy looks like this:
    
       iomem --|
    	   PCI controller 1 MEM space --|
    				        device 1
    					device 2
    					etc.
    	   PCI controller 2 MEM space --|
    				        ...
       ioport --|
                PCI controller 1 IO space --|
    					...
                PCI controller 2 IO space --|
    					...
    
       You get the idea.  The drivers/pci/setup-res.c code allocates
       using plain iomem_space and ioport_space as the root, so that
       wouldn't work with the above setup.
    
       So I added a pcibios_select_root() that is used to handle this.
       It uses the PCI controller struct's io_space and mem_space on
       sparc64, and io{port,mem}_resource on every other platform to
       keep current behavior.
    
    2) quirk_io_region() is buggy.  It takes in raw BUS view addresses
       and tries to use them as a PCI resource.
    
       pci_claim_resource() expects the resource to be fully formed when
       it gets called.  The sparc64 implementation would do the translation
       but that's absolutely wrong, because if the same resource gets
       released then re-claimed we'll adjust things twice.
    
       So I fixed up quirk_io_region() to do the proper pcibios_bus_to_resource()
       conversion before passing it on to pci_claim_resource().
    
    3) I was mistakedly __init'ing the function methods the PCI controller
       drivers provide on sparc64 to implement some parts of these
       routines.  This was, of course, easy to fix.
    
    So we end up with the following, and that nasty SPARC64 makefile
    ifdef in drivers/pci/Makefile is finally zapped.
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    085ae41f
pci.h 8.67 KB